Keyboard shortcuts still sent to site, cause mayhem (Windows, Chrome-likes)

[sschuldenzucker]

If reporting a bug:

1. Can you describe the problem and bug in more detail?

When I try to use the default keyboard shortcuts on certain sites that themselves define some of Memex' alt+XX shortcuts, the keyboard shortcut may or may not do its associated Memex action, but it's also sent to the site to do its action there.

This is most likely undesirable.

2. How can we replicate the issue?

• Go to https://en.wikipedia.org/
• Press alt+x. The tag selector very briefly pops up; then the "Random Article" link in Wikipedia's left sidebar is selected and a random page is loaded. (this closes the tag selector again)
• Press alt+c. The collection selector may or may not very briefly pop up. Wikipedia's "Article" tab is selected and the page is kinda reloaded (not fully though; this still closes the collection selector).

3. Expected behavior (i.e. solution)

IMHO the keyboard shortcuts should only trigger Memex' commands and not be sent to the site. In effect, the site's shortcuts are overridden.

This appears to be the right thing: I have committed the Memex shortcuts to muscle memory and I don't want any website to interfere with that. When in doubt, I can always turn them off temporarily.

5. Other comments

I tested this on Brave and Chrome on Windows and both show the described behavior.

Firefox on Windows does not have the issue and behaves like described in point 3.

Perhaps the right concept are access keys?? On Chrome/Brave/etc., Memex clashes with the access key modifier, but on Firefox, this is not the case.