Bug: Extension gets confused by some page changes

[ricardojmendez]

1. Can you describe the problem and bug in more detail?

Memex doesn't seem to realize that a tab's URL has changed in some cases (likely Javascript).

2. How can we replicate the issue?

• Go to https://www.avclub.com/the-35-best-science-fiction-movies-since-blade-runner-1819142386/slides/35
• Highlight a section.
• Switch to the next slide by pressing the Next button at the bottom. The browser will switch to https://www.avclub.com/the-35-best-science-fiction-movies-since-blade-runner-1819142386/slides/36
• Highlight a section on the new page.
• Click the recently highlighted section to add a comment.

The Memex sidebar will open, and it will show the highlighted section from the previous page, not the current one.

If you press Command-R, then click on the highlight, you'll get the highlights for the correct page.

3. Expected behavior (i.e. solution)

Memex should keep track of which page you're on, even if the URL changed via a Javascript call.

4. Error stack (from extension crash page)

No stack.

5. Other comments

Tested this on Firefox 77.0.1 with Memex 2.1.3

[paveloom]

I've noticed similar behavior with top level files of any repository on GitHub.

How to replicate

1. Load a repository page.
2. Create an annotation or highlight anywhere on the page.
3. Go to another file in the repository (doesn't work when searching for files through t, so try switching to the files at the top level; click Readme.md, for example).
4. If you have any selections or annotations in this file, they will not be displayed. Create a selection or annotation on any non-reference text.
5. Click on it. Boom, you'll see annotations and highlights from the landing (previous) page of the repository.
6. Reload the page. Now you will see the expected annotations and highlights on this page, including those that existed before.