sudachi.rs icon indicating copy to clipboard operation
sudachi.rs copied to clipboard

setup.py install is deprecated

Open mh-northlander opened this issue 5 months ago • 0 comments

We should avoid invoking setup.py directly.

Warning from current github actions log:

********************************************************************************
Please avoid running ``setup.py`` directly.
Instead, use pypa/build, pypa/installer or other
standards-based tools.

See https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html for details.
********************************************************************************

another reference: https://packaging.python.org/en/latest/discussions/setup-py-deprecated/

We should update followings: https://github.com/WorksApplications/sudachi.rs/blob/d09dd0079b48cd307626b7a4a350deddd52ea132/.github/workflows/python-upload-test.yml#L104 https://github.com/WorksApplications/sudachi.rs/blob/d09dd0079b48cd307626b7a4a350deddd52ea132/.github/workflows/docs-deploy.yml#L30 https://github.com/WorksApplications/sudachi.rs/blob/d09dd0079b48cd307626b7a4a350deddd52ea132/.github/workflows/build-python-wheels.yml#L100 https://github.com/WorksApplications/sudachi.rs/blob/d09dd0079b48cd307626b7a4a350deddd52ea132/python/build-sdist.sh#L11 https://github.com/WorksApplications/sudachi.rs/blob/d09dd0079b48cd307626b7a4a350deddd52ea132/python/README.md?plain=1#L380

mh-northlander avatar Jan 24 '24 09:01 mh-northlander