sudachi.rs icon indicating copy to clipboard operation
sudachi.rs copied to clipboard

Can the default resource files be embedded on compile time?

Open yutannihilation opened this issue 1 year ago โ€ข 1 comments

Hi, thanks for developing this great library. I played a bit with R (my repo), but I had to struggle with this error when I tried to make a static binary for users that don't have Rust installed. It seems this error is because Config::new() cannot find the files under resources directory.

Io(Os { code: 3, kind: NotFound, message: "ๆŒ‡ๅฎšใ•ใ‚ŒใŸใƒ‘ใ‚นใŒ่ฆ‹ใคใ‹ใ‚Šใพใ›ใ‚“ใ€‚" })

As the files are not very huge, is it possible to embed them somehow, e.g. using include_str macro, on compile time?

yutannihilation avatar Jul 18 '22 09:07 yutannihilation

Config framework needs to have a complete overhaul. Everything which is present now is a placeholder.

I agree that defaults probably should be embedded in the binary/library as resources.

eiennohito avatar Jul 19 '22 00:07 eiennohito