platform_detect icon indicating copy to clipboard operation
platform_detect copied to clipboard

Support for Microsoft Edge

Open kenzieschmoll opened this issue 5 years ago • 1 comments

Are there plans to support Edge?

If it is already supported, feel free to close this, but I didn't see Edge in the list of known browsers. Thanks.

kenzieschmoll avatar Mar 21 '19 20:03 kenzieschmoll

In the source code, the check for browser.isInternetExplorer looks like this:

 static bool _isInternetExplorer(NavigatorProvider navigator) {
    return navigator.appName.contains('Microsoft') ||
        navigator.appVersion.contains('Trident') ||
        navigator.appVersion.contains('Edge');
  }

I assume this means this will check for Edge. But, I still think the two of them should be separated. I have a website where we support Edge from at least version '17', and where we don't support Internet Explorer at all. If the check browser.isInternetExplorer returns true for both IE and Edge, this will not allow us to differentiate between these...

dotdotcommadot avatar May 15 '19 11:05 dotdotcommadot