json_schema icon indicating copy to clipboard operation
json_schema copied to clipboard

Avoid unnecessary null pointer exception if reference schema is given

Open laurisvan opened this issue 9 months ago • 1 comments

Ultimate problem:

When running an application using json_schema with debugger, I tend to break on every exception. The json_schema initialization unnecessarily tried to parse the contents of _fetchedFromUri, which throws when this value is null.

How it was fixed:

I added an extra null check to avoid JsonSchemaUtils.getBaseFromFullUri call when the parameter is not given.

Testing suggestions:

Potential areas of regression:

None identified.

laurisvan avatar May 10 '24 14:05 laurisvan

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

aviary2-wf avatar May 10 '24 14:05 aviary2-wf

@Workiva/release-management-p

joecotton-wk avatar Jul 24 '24 17:07 joecotton-wk