wporg-mu-plugins
wporg-mu-plugins copied to clipboard
Query Filter: Single option filters don't have accessible names
Initially reported on learn, this is an issue across the site.
The toggle that opens the course status filters is labeled using the currently selected status. Buttons to perform an action should be labeled using information about what the control does. Having the current status visible is OK; but it shouldn't be the only content.
This would be better labeled using something like "Filter Courses: All" or even "Filter: All". This would inform the user what they can do with the control.
The single-select variation of query filter should display "[Filter name]: [Value]" as the button text (label
value).
This has been fixed on Learn in https://github.com/WordPress/Learn/pull/2804
Still needs to be fixed on:
- [x] Themes (only uses multiple select filters)
- [x] Plugins (only has filters if
?show_filters=1
, and this is already using the right format) - [ ] Patterns (curation & sort, remove unused status from "my patterns")
- [ ] Events (technically correct, but the single-select uses the multiple-select label style)
- [ ] Showcase (has sort on archive view)
Question for @WordPress/meta-design:
Once we do this, the label is shown twice. Should the label inside the dropdown be hidden again? This would match the multiple select behavior (it's there, but only visible on mobile).
Desktop | Mobile | |
---|---|---|
Multiple select | ||
Single select |