wordpress-playground icon indicating copy to clipboard operation
wordpress-playground copied to clipboard

Miscellaneous - Cleanup of leftover code or addition of missing code segments.

Open mho22 opened this issue 7 months ago • 0 comments

Occasionally, I come across leftover code from earlier implementations that we could probably clean up.

I'd prefer not to include these cleanups in unrelated PR to avoid confusion. Instead, we could use this issue to track them as we find them and gradually clean up the project over time.

Cleanup

  • [ ] passWithNoTests property in project.json test is a Jest property. NX vitest executor schema here. Other properties are also no longer valid. [ like configurations that can also be removed from ci.yml file ]
  • [ ] Vite cache.dir is deprecated, use cacheDir instead.
  • [ ] WITH_NODEFS in compile/build.js seems to be unused now.
  • [x] Remove obsolete PHP version in supported-php-versions.mjs
  • [ ] Remove commented describe.each(SupportedPHPVersions)( in php-networking.spec.ts
  • [ ] Remove obsolete build property in php-wasm/node/vite.config.js
  • [ ] Remove unnecessary throw new Error('Unsupported PHP version ${version}'); in get-php-loader-module.ts
  • [ ] Remove ASYNCIFY_ONLY with UNPREFIXED duplicatas since pointer casting is disabled now in php/Dockerfile on line 2008
  • [x] Remove WEB wasm version 7_0_33 7_1_30
  • [ ] Remove "Asyncify onlylist contained a non-existing function name" lists
  • [ ] Correct @php-wasm/universal in fs-journal/package.json
  • [ ] Unused import { createRequire } from 'module'; in package/php-wasm/node/build.js
  • [ ] Remove setPluginProxyURL in packages/playground/blueprints/src/index.ts, deprecated.
  • [ ] Fix issues in project.json files related to $schema. e.g. php-wasm/compile/project.json.
  • [ ] Remove last await from packages/playground/website/playwright/e2e
  • [ ] Remove quotes in "test:vite:node" or "test:vite"
  • [ ] Correct deprecated it() use with object option in import-wxr.spec.ts and in overall test files
  • [ ] Correct new File([fileData],... in import-wxr.spec.ts

Addition

  • [ ] Refactor followSymlinks inside load-runtime to a separate file.
  • [ ] getPHPLoaderModule in load-runtime should be called first, if a PHP version doesn't exist.
  • [ ] There is no removal of dist directories for libcurl in compile/Makefile : rm -rf ./libcurl/jspi/dist & rm -rf ./libcurl/asyncify/dist
  • [ ] Replace php.run() with php.runStream() everywhere in project.
  • [ ] Add dev command in project.json to run as JSPI or ASYNCIFY
  • [ ] Move php-wasm-web tests in tests directory in src
  • [ ] Misspelling word 'belos' in php.ts
  • [ ] Remove old PHP version directory if a new directory is created
  • [ ] test-opcache in php-wasm/node/project.json is never called
  • [ ] Replace WITH_JSPI with JSPI in compile/build.js. Same for WITH_DEBUG.
  • [ ] Fuse ignore-wasm-imports, ignore-lib-imports and ignore-data-imports into ignore-binary-imports and add it in the vite-extensions directory. Load it in php-wasm-web vite.config.ts.
  • [ ] Install eslint-plugin-playwright and add the no-focused-test rule

mho22 avatar Jun 05 '25 08:06 mho22