wordpress-playground
wordpress-playground copied to clipboard
Miscellaneous - Cleanup of leftover code or addition of missing code segments.
Occasionally, I come across leftover code from earlier implementations that we could probably clean up.
I'd prefer not to include these cleanups in unrelated PR to avoid confusion. Instead, we could use this issue to track them as we find them and gradually clean up the project over time.
Cleanup
- [ ]
passWithNoTestsproperty in project.json test is a Jest property. NX vitest executor schema here. Other properties are also no longer valid. [ like configurations that can also be removed from ci.yml file ] - [ ] Vite cache.dir is deprecated, use cacheDir instead.
- [ ]
WITH_NODEFSincompile/build.jsseems to be unused now. - [x] Remove obsolete PHP version in
supported-php-versions.mjs - [ ] Remove commented
describe.each(SupportedPHPVersions)(inphp-networking.spec.ts - [ ] Remove obsolete
buildproperty inphp-wasm/node/vite.config.js - [ ] Remove unnecessary
throw new Error('Unsupported PHP version ${version}');inget-php-loader-module.ts - [ ] Remove ASYNCIFY_ONLY with UNPREFIXED duplicatas since pointer casting is disabled now in
php/Dockerfileon line2008 - [x] Remove WEB wasm version 7_0_33 7_1_30
- [ ] Remove "Asyncify onlylist contained a non-existing function name" lists
- [ ] Correct
@php-wasm/universalinfs-journal/package.json - [ ] Unused
import { createRequire } from 'module';inpackage/php-wasm/node/build.js - [ ] Remove
setPluginProxyURLinpackages/playground/blueprints/src/index.ts, deprecated. - [ ] Fix issues in project.json files related to
$schema. e.g.php-wasm/compile/project.json. - [ ] Remove last
awaitfrompackages/playground/website/playwright/e2e - [ ] Remove quotes in
"test:vite:node"or"test:vite" - [ ] Correct deprecated it() use with object option in
import-wxr.spec.tsand in overall test files - [ ] Correct
new File([fileData],...inimport-wxr.spec.ts
Addition
- [ ] Refactor
followSymlinksinsideload-runtimeto a separate file. - [ ]
getPHPLoaderModuleinload-runtimeshould be called first, if a PHP version doesn't exist. - [ ] There is no removal of dist directories for
libcurlincompile/Makefile:rm -rf ./libcurl/jspi/dist & rm -rf ./libcurl/asyncify/dist - [ ] Replace
php.run()withphp.runStream()everywhere in project. - [ ] Add
devcommand inproject.jsonto run as JSPI or ASYNCIFY - [ ] Move php-wasm-web tests in tests directory in src
- [ ] Misspelling word 'belos' in php.ts
- [ ] Remove old PHP version directory if a new directory is created
- [ ]
test-opcacheinphp-wasm/node/project.jsonis never called - [ ] Replace
WITH_JSPIwithJSPIin compile/build.js. Same forWITH_DEBUG. - [ ] Fuse
ignore-wasm-imports,ignore-lib-importsandignore-data-importsintoignore-binary-importsand add it in thevite-extensionsdirectory. Load it inphp-wasm-webvite.config.ts. - [ ] Install
eslint-plugin-playwrightand add the no-focused-test rule