wordpress-playground icon indicating copy to clipboard operation
wordpress-playground copied to clipboard

Some NPM packages do not have a README

Open psrpinto opened this issue 1 year ago • 1 comments

The following packages do not have a README.md at npmjs.com, even though they do contain a README.md in their source:

The README is missing from the packages because the vite build removes it, I believe.

Using @wp-playground/client as an example, when running npx nx build playground-client, one can see the README.md initially being placed under dist/, and then being removed once the vite build completes.

psrpinto avatar Oct 19 '24 22:10 psrpinto

@psrpinto in https://github.com/WordPress/wordpress-playground/pull/1924 you touched on something important.

We need to figure out where to store developer content relevant to the source code and how to separate it from the NPM package description.

bgrgicak avatar Oct 23 '24 09:10 bgrgicak

Including the developer README.md directly with these packages would be better than nothing for now. I'd still love to have dedicated README files for npm but yeah, that will take more time and effort.

adamziel avatar Nov 13 '24 15:11 adamziel

Makes sense, I'll assign this to myself and fix the issue of vite removing the READMEs. That will result in the existing READMEs being published with the packages.

psrpinto avatar Nov 15 '24 14:11 psrpinto

Thank you Paulo!

adamziel avatar Nov 15 '24 20:11 adamziel

I’ll reopen this until the readme shows up on npm

adamziel avatar Feb 27 '25 08:02 adamziel

@php-wasm/universal, @php-wasm/fs-journal, and @php-wasm/logger are still missing readmes. I will take another look at it.

bgrgicak avatar Feb 27 '25 09:02 bgrgicak

The @wp-playground/cli has a new README, I can have a look at other packages.

fellyph avatar Jul 14 '25 11:07 fellyph

@wp-playground/client would be really useful, the rest should be fine without a readme. Well, Blueprints could use one, but we're about to merge https://github.com/WordPress/wordpress-playground/pull/2281 so it doesn't make as much sense to write a lot about v1 now.

adamziel avatar Jul 14 '25 14:07 adamziel