Canonical URL Tests for Attachments

[SirLouen]

Combined Test Report and Unit Tests Patch

Description

This report validates that the indicated patch works as expected.

Patch tested: https://github.com/WordPress/wordpress-develop/pull/8435.diff

Environment

• WordPress: 6.8-beta3-60042-src
• PHP: 8.2.28
• Server: nginx/1.27.4
• Database: mysqli (Server: 8.4.4 / Client: mysqlnd 8.2.28)
• Browser: Chrome 134.0.0.0
• OS: Windows 10/11
• Theme: My Twenty Twenty Child Theme 1.0
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0

Testing Instructions without the Patch

1. Enable wp_attachment_pages_enabledin the wp_options table (change 0 to 1)
2. Upload an image to Media > Add Media File
3. Click on Edit and then click on the Media Permalink
4. Check the source code for a canonical tag.

Expected result

The canonical tag is in the code

Results without the Patch

1. 🐞 Bug occurs.

Results with the Patch

1. ✅ Issue resolved with patch.

Additional Notes

I have also sorted all the PHPCS issues in the wpGetCanonicalUrl.php file (only missing comments)

Props to @Infinite-Null for the patch https://github.com/WordPress/wordpress-develop/pull/8435 Also Props to @othernoel who clearly hinted the patch solution in the report.

Trac ticket: https://core.trac.wordpress.org/ticket/63041

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[github-actions[bot]]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sirlouen.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions[bot]]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance, it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[github-actions[bot]]

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 60108 GitHub commit: https://github.com/WordPress/wordpress-develop/commit/ca8b2f54f13354c83d34aecd359159548b5e2612

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.