Canonical URL Tests for Attachments

[SirLouen]

Combined Test Report and Unit Tests Patch

Description

This report validates that the indicated patch works as expected.

Patch tested: https://github.com/WordPress/wordpress-develop/pull/8435.diff

Environment

• WordPress: 6.8-beta3-60042-src
• PHP: 8.2.28
• Server: nginx/1.27.4
• Database: mysqli (Server: 8.4.4 / Client: mysqlnd 8.2.28)
• Browser: Chrome 134.0.0.0
• OS: Windows 10/11
• Theme: My Twenty Twenty Child Theme 1.0
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0

Testing Instructions without the Patch

1. Enable wp_attachment_pages_enabledin the wp_options table (change 0 to 1)
2. Upload an image to Media > Add Media File
3. Click on Edit and then click on the Media Permalink
4. Check the source code for a canonical tag.

Expected result

The canonical tag is in the code

Results without the Patch

1. 🐞 Bug occurs.

Results with the Patch

1. ✅ Issue resolved with patch.

Additional Notes

I have also sorted all the PHPCS issues in the wpGetCanonicalUrl.php file (only missing comments)

Props to @Infinite-Null for the patch https://github.com/WordPress/wordpress-develop/pull/8435 Also Props to @othernoel who clearly hinted the patch solution in the report.

Trac ticket: https://core.trac.wordpress.org/ticket/63041

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.