wordpress-develop icon indicating copy to clipboard operation
wordpress-develop copied to clipboard

Preserve target="_blank" in Biographical Info and Taxonomy Description

Open nirajgiriXD opened this issue 1 year ago • 4 comments

Description

This PR ensures that target="_blank" is preserved in the Biographical Info and Taxonomy Description fields to maintain the intended link behavior.

Trac ticket: https://core.trac.wordpress.org/ticket/12056

nirajgiriXD avatar Jun 20 '24 13:06 nirajgiriXD

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @[email protected].

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props martinkrcho, nirajgirixd, audrasjb.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] avatar Jun 20 '24 13:06 github-actions[bot]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance, it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

github-actions[bot] avatar Jun 20 '24 13:06 github-actions[bot]

This change will affect the behaviour of all kses_* functions. I am not sure if that is desired.

martinkrcho avatar Jun 21 '24 08:06 martinkrcho

@martinkrcho You are right; changing the $allowedtags would indeed affect the behaviour of all kses_* functions, which might not be ideal. I have revised my approach, and the new method should not cause any issues.

nirajgiriXD avatar Jun 24 '24 06:06 nirajgiriXD

@martinkrcho Could you please take a look at the PR and let me know if the new changes are satisfactory?

nirajgiriXD avatar Oct 03 '24 07:10 nirajgiriXD

@nirajgiriXD I prefer this approach to the previous one. It affects only a limited number of filters.

Would you be able to provide unit tests or provide instructions for manual testing (in the Trac ticket)?

martinkrcho avatar Oct 03 '24 07:10 martinkrcho

@martinkrcho I've added the testing instructions along with some screenshots to the PR description.

nirajgiriXD avatar Oct 03 '24 10:10 nirajgiriXD

Closed in favor of https://github.com/WordPress/wordpress-develop/pull/7792

audrasjb avatar Dec 12 '24 09:12 audrasjb

closed in favor of https://github.com/WordPress/wordpress-develop/pull/7792

audrasjb avatar Dec 12 '24 09:12 audrasjb