wordpress-develop icon indicating copy to clipboard operation
wordpress-develop copied to clipboard

Backport: Global Styles: Add scoping of feature level selectors

Open aaronrobertshaw opened this issue 9 months ago • 4 comments

Syncs the changes from:

  • https://github.com/WordPress/gutenberg/pull/61033

These changes ensure that custom feature-level selectors for style nodes are correctly scoped when generating a theme.json stylesheet

Unit tests: npm run test:php -- --filter Tests_Theme_wpThemeJson

Screenshot 2024-05-02 at 12 15 45 PM

Trac ticket: https://core.trac.wordpress.org/ticket/61119


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

aaronrobertshaw avatar May 02 '24 02:05 aaronrobertshaw

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props aaronrobertshaw, audrasjb, vcanales.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] avatar May 02 '24 02:05 github-actions[bot]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance, it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

github-actions[bot] avatar May 03 '24 00:05 github-actions[bot]

👋 @audrasjb @aaronrobertshaw any updates here?

vcanales avatar May 20 '24 08:05 vcanales

All the feedback to date has been addressed and we're just waiting on an approval.

aaronrobertshaw avatar May 21 '24 00:05 aaronrobertshaw

Committed in r58244.

tellthemachines avatar May 30 '24 04:05 tellthemachines