two-factor icon indicating copy to clipboard operation
two-factor copied to clipboard

Add <label> to provider name

Open r-a-y opened this issue 5 years ago • 3 comments

Hi,

This PR wraps the provider name with the <label> element for better UX.

GIF:

GIF

I've also renamed the Name column to Type since this column also has buttons depending on the provider (TOTP, Backup Verification Codes). I can revert this if this isn't desired.

r-a-y avatar Oct 03 '20 22:10 r-a-y

@georgestephanis / @kasparsd any thoughts on a review of this PR and whether it's ready for consideration in v0.8.0?

jeffpaul avatar May 10 '21 15:05 jeffpaul

Given that we're looking at a larger UX review of this part of the plugin and that in yesterday's bug scrub @georgestephanis is not certain the label targeting the tickbox instead of the radio button when the radio button is closer and that it might be possible to flip those columns as well; I'm going to punt this to a future release to slim down our focus for 0.8.0 to handle the larger U2F deprecation.

jeffpaul avatar Mar 24 '22 18:03 jeffpaul

Given that we're looking at a larger UX review of this part of the plugin

Yeah, the Enabled / Primary UX needs to be overhauled (see #342). I'm injecting the labels with some javascript at the moment as a workaround until the interface is reworked at some point.

r-a-y avatar Mar 24 '22 19:03 r-a-y

This is a great UX and accessibility improvement. Let's merge this in.

kasparsd avatar Oct 07 '22 09:10 kasparsd