twentytwentythree icon indicating copy to clipboard operation
twentytwentythree copied to clipboard

Remove opinionated settings from block markup

Open mikachan opened this issue 3 years ago • 3 comments

As TT3 is focused on style variations, it would be good to remove as many opinionated styles from the block markup as possible. There are a few places where this is happening, but sometimes it can be difficult where unique styles have been required. Here's an example of where we have done this previously: https://github.com/WordPress/twentytwentythree/pull/31

This issue is to track where we could consider moving these settings, and encourage discussion around this for each area:

  • [x] 404 pattern: https://github.com/WordPress/twentytwentythree/pull/93
  • [x] Search template: https://github.com/WordPress/twentytwentythree/pull/103
  • [ ] Home template: https://github.com/WordPress/twentytwentythree/pull/94

mikachan avatar Aug 19 '22 16:08 mikachan

I agree 404 can become much smaller:

Captura de ecrã 2022-08-22, às 09 53 33

About Search and Home, I'm not sure. What changes do you think could be done to make it less opinionated?

beafialho avatar Aug 22 '22 08:08 beafialho

I don't see that the xx-large size has been used anywhere yet. Would it make sense to use that value, but maybe crank it up a bit? I'm actually keen to keep the value on the 404 page (font-size:clamp(4rem, 40vw, 20rem) or something close to it) for xx-large (which feels like "the upper end of sizes we should create").

pbking avatar Aug 22 '22 21:08 pbking

I didn't notice any opinion in the search template that we might want to relocate (other than some spacing bits that are already being addressed in #52

pbking avatar Aug 23 '22 01:08 pbking

I'm going to close this, as I think we've currently removed as much opinion as possible from the templates. Please open another issue if you spot anything similar.

mikachan avatar Sep 02 '22 12:09 mikachan