theme-review-action icon indicating copy to clipboard operation
theme-review-action copied to clipboard

Block theme specific testing

Open StevenDufresne opened this issue 4 years ago • 3 comments

Which block-based theme-specific tests are needed?

Ideas based on documentation: https://github.com/WordPress/gutenberg/tree/trunk/docs/how-to-guides/block-based-theme

  • Validate experimental-theme.json
  • Make sure block-template-part exists if included in block-templates. (It fails quietly)
  • Make sure it doesn't include non-core blocks? (Edit: It can)

StevenDufresne avatar Mar 26 '21 03:03 StevenDufresne

Reopening this issue to add more information and test ideas.

StevenDufresne avatar Mar 30 '21 00:03 StevenDufresne

As I read the list of blockers and flags provided here https://make.wordpress.org/themes/2021/03/17/next-steps-on-themes-and-reviews/ non-core blocks are allowed.

For example, you may want to build a web shop with WooCommerce blocks. The blocks will error in the editor until the plugin is installed, and should show nothing on the front.

carolinan avatar Mar 30 '21 07:03 carolinan

The tutorial here is very outdated https://github.com/WordPress/gutenberg/tree/trunk/docs/how-to-guides/block-based-theme The theme.json file can not be validated until it is more stable. Planned changes: https://github.com/WordPress/gutenberg/issues/29891

I do feel like Gutenberg should provide the validation for this file 🤔

carolinan avatar Mar 30 '21 07:03 carolinan