theme-review-action icon indicating copy to clipboard operation
theme-review-action copied to clipboard

The accessible menu test is incorrect

Open carolinan opened this issue 4 years ago • 3 comments

The menu check is incorrect; opening a sub menu on hover must not be required. Hovering is the least accessible way. It should not even be mentioned as recommended.

carolinan avatar Mar 15 '21 16:03 carolinan

I took that from the theme review documentation here:

https://make.wordpress.org/themes/handbook/review/accessibility/required/#keyboard-navigation

Fails: Dropdown navigation menus are hidden using display:none; and brought into view on :hover Passes: Dropdown navigation menus are hidden using position: absolute; and brought into view on :hover and :focus, and are navigable using the tab key Better: Dropdown navigation menus are hidden using position: absolute; and brought into view on :hover, :focus, and are navigable using either the tab key or by using the keyboard arrow keys

StevenDufresne avatar Mar 16 '21 00:03 StevenDufresne

This is why I tried to express that checking the menu is not that simple. That opening sub menus on hover is allowed -as long as the keyboard navigation also works -is not the same as hover being required.

If opening sub menus on hover was required, then that would exclude any theme where you open submenus by clicking a button.

I want to check the tests thoroughly and with help from the accessibility team, but I will not be able to do that until after the 5.8 FSE MVP dates.

carolinan avatar Mar 17 '21 01:03 carolinan

We can cycle back on these tests seeing that they are considered warnings. I'll create a warning document to make the distinction and lessen their importance... same for the a11y tests.

We can focus on the error cases first which are definitely more straightforward.

StevenDufresne avatar Mar 17 '21 02:03 StevenDufresne