theme-experiments icon indicating copy to clipboard operation
theme-experiments copied to clipboard

Tag theme releases

Open ockham opened this issue 4 years ago • 5 comments

Hey, would y'all be okay with tagging theme versions (i.e. using git tags)? E.g. assigning the tag [email protected] to https://github.com/WordPress/theme-experiments/commit/f3d2c0dac4dd6a127b177178c5145c10f28401af.

This would make it simpler and more transparent to refer to this GH repo as a source from other places.

The concrete motivation for this is https://github.com/WordPress/gutenberg/issues/28692#issuecomment-772797992: It'd allow us to pin Gutenberg's (end-to-end test) dependency to

WordPress/theme-experiments/tt1-blocks#[email protected]

rather than

WordPress/theme-experiments/tt1-blocks#f3d2c0d

ockham avatar Feb 04 '21 15:02 ockham

I am not sure how to create (and tag) a release with only the theme - @aristath @kjellr do we create a new branch for only TT1 Blocks?

carolinan avatar Feb 05 '21 07:02 carolinan

I am not sure how to create (and tag) a release with only the theme - @aristath @kjellr do we create a new branch for only TT1 Blocks?

I don't think there needs to be a separate branch, nor does the tag have to include one theme only! The tag would really just serve as a pointer that indicates the snapshot of the repo that reflects a given version of the theme -- it's perfectly fine to ignore what's going on with the other themes. (We do this in the Gutenberg repo -- if you look at the tags list there, there are e.g. tags for individual versions of each @wordpress/ package.)

ockham avatar Feb 05 '21 23:02 ockham

I am not sure if I did this correctly https://github.com/WordPress/theme-experiments/releases/tag/tt1-blocks%400.4.3

https://github.com/WordPress/theme-experiments/tags

carolinan avatar Feb 08 '21 04:02 carolinan

I think what you did there works Carolina — since this is a monorepo, I think we can just ignore the other themes when we package. Thanks for tagging this release!

kjellr avatar Feb 08 '21 14:02 kjellr

Thanks a lot @carolinan, this looks perfect :+1:

ockham avatar Feb 08 '21 17:02 ockham