sqlite-database-integration icon indicating copy to clipboard operation
sqlite-database-integration copied to clipboard
verified publisher icon WordPress

PHP 8.5 Compatibility

Open swissspidy opened this issue 3 months ago • 2 comments

Getting some deprecation warnings:

Deprecated: Method PDO::sqliteCreateFunction() is deprecated since 8.5, use Pdo\Sqlite::createFunction() instead in /.../wp-content/mu-plugins/sqlite-database-integration/wp-includes/sqlite/class-wp-sqlite-pdo-user-defined-functions.php on line 34

Otherwise seems fine at first glance.

swissspidy avatar Sep 04 '25 12:09 swissspidy

I tried to run all unit tests with PHP 8.5 in https://github.com/WordPress/sqlite-database-integration/pull/235, but I'm confused about why I see no deprecations: https://github.com/WordPress/sqlite-database-integration/actions/runs/17492452396/job/49685179930

It appears they should be reported 🤔

JanJakes avatar Sep 05 '25 12:09 JanJakes

Maybe that particular code path is not tested or so?

The PHP version looks correct though, the latest nightly already includes the deprecation (see https://github.com/php/php-src/commit/a4afc57f1d5f59296998ef5e3187ca42c0ab1166)

swissspidy avatar Sep 05 '25 12:09 swissspidy