plugin-check icon indicating copy to clipboard operation
plugin-check copied to clipboard

When checking for excluded files, use the normalized path to ensure that it works in Windows environments.

Open pbiron opened this issue 1 year ago • 1 comments

Fixes #693

pbiron avatar Oct 03 '24 17:10 pbiron

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: pbiron <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: ernilambar <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] avatar Oct 03 '24 17:10 github-actions[bot]

@davidperezgar can you please look at this PR before v1.2.0 ships?

pbiron avatar Oct 08 '24 01:10 pbiron

I don't know for sure, we're in final stages of version.

davidperezgar avatar Oct 08 '24 18:10 davidperezgar

the reason I would really like to get it into 1.2.0 is that it is a follow-up to #592 which will be included in 1.2.0. #592 fixed one prob for the WP_CLI command in Windows but missed another one.

pbiron avatar Oct 08 '24 18:10 pbiron

I don't have Windows setup to test the PR. Can someone please verify who is in Windows OS?

ernilambar avatar Oct 20 '24 08:10 ernilambar

I trust that @pbiron did the necessary testing when fixing this bug on their machine :)

swissspidy avatar Oct 23 '24 11:10 swissspidy