plugin-check
plugin-check copied to clipboard
Add valid checks slug array and warning for non-existent checks
A function return_valid_check_slugs() has been added to the file Abstract_Check_Runner.php to filter out any non-existent checks from the $check_slugs array. It also echos a warning if a slug from the passed array does not exist. This enhancement is reflected in the WP CLI --checks argument as noted in the readme documentation.
This is for the issue https://github.com/WordPress/plugin-check/issues/348
IMO that‘s the wrong approach to add such validation. This claas shouldn‘t arbitrarily output stuff using echo.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Co-authored-by: alewolf <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: davidperezgar <[email protected]>
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
@alewolf Could you resolve the conflicts?
@davidperezgar I would, if the tests would show whats wrong.
Resolve the conflicts and it will run the tests again.
@davidperezgar What conflicts? Speficics please.
Here:
The merge commit.
@davidperezgar Ok. Conflicts have been resolved.