performance icon indicating copy to clipboard operation
performance copied to clipboard

Improve Test Coverage for Auto Sizes Plugin

Open sarthak-19 opened this issue 10 months ago • 2 comments

Summary

This is part of https://github.com/WordPress/performance/issues/1789:

  • Ignore Coverage for Non-Critical Code Blocks
  • Add Missing @covers Annotations
  • Add Missing Tests
Before : 79.00% ⚠️ After: 95.00% ✅
image  image

cc : @westonruter

sarthak-19 avatar Feb 18 '25 16:02 sarthak-19

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.53%. Comparing base (1fc81a3) to head (3a983f2). :warning: Report is 19 commits behind head on trunk.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk    #1879      +/-   ##
==========================================
+ Coverage   68.21%   68.53%   +0.32%     
==========================================
  Files          93       91       -2     
  Lines        7947     7930      -17     
==========================================
+ Hits         5421     5435      +14     
+ Misses       2526     2495      -31     
Flag Coverage Δ
multisite 68.53% <ø> (+0.32%) :arrow_up:
single 35.78% <ø> (+0.22%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Feb 18 '25 16:02 codecov[bot]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @[email protected].

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: [email protected].

Co-authored-by: sarthak-19 <[email protected]>
Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: pravinparmar2404 <[email protected]>
Co-authored-by: westonruter <[email protected]>
Co-authored-by: phanduynam <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] avatar Feb 18 '25 19:02 github-actions[bot]

This issue has been resolved, please close it admin

phanduynam avatar Apr 03 '25 13:04 phanduynam

@sarthak-19 Could you please resolve the conflict and address the feedbacks?

mukeshpanchal27 avatar Jun 23 '25 06:06 mukeshpanchal27

@mukeshpanchal27 Will do today 😅

sarthak-19 avatar Jun 23 '25 06:06 sarthak-19

@sarthak-19 @westonruter I’m going to merge these PR.

Since they don’t affect production code and only improve test coverage, any remaining items can be addressed in a separate follow-up PR.

mukeshpanchal27 avatar Aug 19 '25 04:08 mukeshpanchal27