performance icon indicating copy to clipboard operation
performance copied to clipboard

Accurate sizes: Get accurate sizes base on ancestor block context

Open mukeshpanchal27 opened this issue 11 months ago • 6 comments

Summary

  • Introduces an initial proof of concept (POC) to return accurate sizes based on ancestor block context.
  • This PR does not address all the use cases described in #1511.
  • Includes some unit tests that may require updates or extensions.
  • Additional unit tests will be added in future iterations.

See #1511

mukeshpanchal27 avatar Jan 22 '25 06:01 mukeshpanchal27

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.59%. Comparing base (7757e50) to head (80cc029). Report is 16 commits behind head on feature/1511-incorporate-layout-constraints-from-ancestors.

Additional details and impacted files
@@                                      Coverage Diff                                       @@
##           feature/1511-incorporate-layout-constraints-from-ancestors    #1818      +/-   ##
==============================================================================================
+ Coverage                                                       69.41%   69.59%   +0.18%     
==============================================================================================
  Files                                                              86       86              
  Lines                                                            7006     7018      +12     
==============================================================================================
+ Hits                                                             4863     4884      +21     
+ Misses                                                           2143     2134       -9     
Flag Coverage Δ
multisite 69.59% <100.00%> (+0.18%) :arrow_up:
single 39.66% <100.00%> (+0.23%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jan 22 '25 06:01 codecov[bot]

@joemcgill This one ready for your review.

mukeshpanchal27 avatar Jan 22 '25 09:01 mukeshpanchal27

The PR is ready for internal review.

mukeshpanchal27 avatar Mar 25 '25 09:03 mukeshpanchal27

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: westonruter <[email protected]>
Co-authored-by: felixarntz <[email protected]>
Co-authored-by: phanduynam <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] avatar Mar 26 '25 05:03 github-actions[bot]

What‘s with the failing tests?

swissspidy avatar Mar 26 '25 06:03 swissspidy

What‘s with the failing tests?

In https://github.com/WordPress/performance/pull/1818/commits/3a51aed436225312d53a8ad8c5e4dfe273b177f7 it will skip failed tests for WordPress versions lower than 6.8

mukeshpanchal27 avatar Mar 27 '25 04:03 mukeshpanchal27

This issue has been resolved, please close it admin

phanduynam avatar Apr 03 '25 13:04 phanduynam