openverse icon indicating copy to clipboard operation
openverse copied to clipboard

Add envfile rotation DAG

Open sarayourfriend opened this issue 5 months ago • 0 comments

Fixes

Fixes https://github.com/WordPress/openverse-infrastructure/issues/968 by @sarayourfriend

Description

Adds a DAG to rotate the envfiles in the environment files buckets. The DAG finds the 3 most recent envfiles for each service, and then deletes everything else in the buckets.

Drafted because I'm still trying to understand how best to test this. @stacimc @AetherUnbound if either of y'all have any input/ideas about how to test this, please let me know. I've tried changing the AWS connection locally to test the listing logic, but Airflow expects to be able to write logs to S3 using those same connection credentials, so the tasks fail immediately when they can't write to the logs bucket. Should I give up trying to test against the real buckets and just mock responses out in unit tests? That's about as good as just trying to run it in production and seeing what happens, as it'll depend entirely on whether I get the mocks right... and there's no sure-fire way to test that with our current tools, as far as I know. I've seen this moto library mentioned around before as a good way to mock AWS resources but we don't use it at all, and it's missing implementation for describe_launch_template_versions anyway... it might still be useful for other parts.

Let me know what y'all think. I'll leave this drafted until then/until I come up with something on my own. Thanks in advance.

Testing Instructions

TBD.

Checklist

  • [x] My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • [x] My pull request targets the default branch of the repository (main) or a parent feature branch.
  • [x] My commit messages follow best practices.
  • [x] My code follows the established code style of the repository.
  • [ ] I added or updated tests for the changes I made (if applicable).
  • [x] I added or updated documentation (if applicable).
  • [x] I tried running the project locally and verified that there are no visible errors.
  • [ ] I ran the DAG documentation generator (ov just catalog/generate-docs for catalog PRs) or the media properties generator (ov just catalog/generate-docs media-props for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

sarayourfriend avatar Sep 18 '24 06:09 sarayourfriend