openverse icon indicating copy to clipboard operation
openverse copied to clipboard

Consider removing the renovate validator from local pre-commit linting

Open sarayourfriend opened this issue 7 months ago • 1 comments

Problem

Once installed, the renovate validator is fast. However, it's a gnarly dependency to install and takes forever compared to the other modules (literally comparing minutes with renovate validator to seconds with the others, even on my overpowered computer!)

Description

Maybe we can rely just on CI for this one?

Alternatives

Keep it and accept that it takes a long time to create the pre-commit envs.

If there is a binary distribution of the tool, we could include it in ov base image, and use it directly, instead of the pre-commit hook which installs it from scratch with node-gyp.

Additional context

It's mostly come up for me as a result of working on ov, and ov clean forcing a recreation of the pre-commit environments. Normally it isn't an issue, but I could see it as a frustrating part of environment setup.

sarayourfriend avatar Jun 27 '24 01:06 sarayourfriend