openverse-frontend icon indicating copy to clipboard operation
openverse-frontend copied to clipboard

Add a disabled style to three components

Open fcoveram opened this issue 2 years ago • 5 comments

Problem

As noted in tickets #1791 and #1790, some components need a "disabled" state to deny the use of some features, but the current Design Library does not have styles for the Content switcher and Filters components.

Description

To make this state visually consistent with other components, the Design Library was updated with a new variant in each Figma component mentioned. Here is the style for each one

Content switcher

Filters

Filters value

In all components, the style has dark-charcoal-10 as the background color, and dark-charcoal-40 for texts and icons.

Pointer update

As also noted and developed in #1790 it would be great to implement a style change in the pointer for all current and upcoming components, like the example below.

Implementation

  • [ ] 🙋 I would be interested in implementing this feature.

fcoveram avatar Sep 08 '22 15:09 fcoveram

Hi @dhruvkb . I would like to work on this issue. Please assign this to me.

sourav25998 avatar Sep 10 '22 11:09 sourav25998

Sure @sourav25998. Please go ahead.

dhruvkb avatar Sep 10 '22 11:09 dhruvkb

Hi @dhruvkb . I'll be continuing with my issue that has been assigned to me in openverse-api at the moment. I shall come back to frontend once I am done with that issue. Thus, I am unassigning myself from this issue right now. Hope you understand

sourav25998 avatar Sep 12 '22 08:09 sourav25998

Hi @dhruvkb , It seems @sourav25998 is continuing with another issue, so I would like to work on this instead. This issue is likely to be a good start of my journey towards contribution to FOSS projects. Please assign this to me.

vinzesiddharth29 avatar Sep 12 '22 08:09 vinzesiddharth29

I've self-assigned this issue because it's been a while, and it's marked as high priority. If you are interested in contributing, @vinzesiddharth29, please feel free to select another issue, and to reach out to the maintainers on the public Slack channel.

obulat avatar Oct 18 '22 15:10 obulat