meta-environment icon indicating copy to clipboard operation
meta-environment copied to clipboard

false versus False

Open tomjn opened this issue 6 years ago • 2 comments

I suspect that the reason that provisioning doesn't work unless you provision everything is because shyaml returns True or False for boolean values, but the provisioner checks for false:

if [[ `wme_provision_site "${SITE_DOMAIN}"` == 'false' ]]; then
	echo "Provisioning of ${SITE_DOMAIN} skipped"
	return
fi

I would also keep in mind that searching in subfolders for provisioners is slower, and the goal of the VVV project longterm is to deprecate such behaviour.

A provision/vvv-init.sh or a .vvv/vvv-init.sh that calls these other provisioners would greatly improve provisioning speed, and future proof things. VVV searches 3 folders deep at the moment, but if either of those folders/files exist, it will load them and skip the file system search, which can be particularly slow on older computers

tomjn avatar Jan 13 '19 21:01 tomjn

Thanks Tom, that's very helpful insight!

iandunn avatar Jan 15 '19 02:01 iandunn

If in doubt you can vagrant ssh and run the shyaml command to see exactly what it returns

tomjn avatar Jan 15 '19 02:01 tomjn