health-check
health-check copied to clipboard
WordPress
Button styling not consistent with core styling
Not sure why the buttons font-size is bigger than the standard in core:
If Health Check is going to be part of core, I'd say it should just use the core styles. No exceptions, consistency is important.
Yes, the font size is slightly larger here, and for text in general (it's 1rem, translating to 16px, as opposed to the 13px core uses), this is done for readability.
For the plugin it self I'd like to experiment with it as screens get larger for desktops, and handheld devices also get higher resolutions the font size feels more readable.
I have no problem removing these style overrides from any core patch though 👍
I might understand a 16 pixels font size for normal text, though inconsistent with core. Ideally, these changes should be evaluated holistically. I'd tend to think having some admin pages with a default font size of 13 pixels and other pages with a default font size of 16 pixels is not ideal.
Re: buttons, they really don't look OK with a bigger font because the buttons size is crafted for a smaller font.
I agree with your thoughts here.
We'll not include the font changes in the core patch, I'd still like to evaluate how they work out in general for the plugin by it self, as I've heard feedback on the fonts being too small in general, perhaps this is a good way to test the need for a larger core font size at a later date..?
If possible I'd like us to make a start on the font size matter right away - doesn't have to be via this project but as you say holistically. We've been tinkering with our product styling at Yoast, and anything that looks good in regular web context looks huge when put next to the small WordPress font. I'll raise it in the design meeting this week to test the waters.
FWIW: I'd agree the WordPress default font size is too small with today's screens 🙂 However, the point is Health Check should just look like a WordPress admin page.
Well, FWIW, these pages are styled like Gutenberg which is what no other admin page has done yet ;) but consistency in text and buttons is fine yes.
Having re-visited this, the styling matches the core styles at this time, so I'll close out this ticket for now :)