WordPress
Accordion Block open/close icon #73607
What?
Closes #73607
Add custom open/close icons for accordion block
Why?
Gives the user ability to add custom icons of their own to expand and collapse the accordion drawer
How?
Added new block settings in accordion block to upload the custom icons for open and close separately, if not set as custom falls back to default
Testing Instructions
- Open a new page/post
- Add accordion block
- Go to block settings and upload a custom icon using upload button
Testing Instructions for Keyboard
None
Screenshots or screencast
:wave: Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @saranshsinhaa! In case you missed it, we'd love to have you join us in our Slack community.
If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Warning: Type of PR label mismatch
To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
- Required label: Any label starting with
[Type]. - Labels found: First-time Contributor.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
Unlinked Accounts
The following contributors have not linked their GitHub and WordPress.org accounts: @JakJakson.
Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Unlinked contributors: JakJakson.
Co-authored-by: saranshsinhaa <[email protected]>
Co-authored-by: ajitbohra <[email protected]>
Co-authored-by: t-hamano <[email protected]>
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
From a features perspective, it looks good; however, issue #73214 is still pending technical feedback.
