WordPress
Separator: Surfacing the HTML markup control
What?
Closes #70441
Reverts the HTML element control in the Separator block back to the Advanced Inspector panel to restore consistent UI patterns and improve overall usability.
Why?
In PR #70185, the HTML element control was moved from the Advanced Inspector to the top-level Settings panel to improve accessibility. However, this change created a significant usability regression.
How?
This PR reverts the UI changes from #70185 by:
- Moving the
HtmlElementControlback toInspectorAdvancedControls - Keeping the helpful control itself (just moving its location)
Testing Instructions
- Open the WordPress block editor (post or page)
- Insert a Separator block
- Open the block settings in the sidebar
- Click on the "Advanced" section at the bottom of the inspector
- Verify that the "HTML element" control is present and functional
- Test changing between
<hr>and<div>options - Confirm the separator renders with the correct HTML element in both editor and frontend
Screenshots or screencast
| Before (Current) | After (This PR) |
|---|---|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Co-authored-by: Infinite-Null <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: karmatosed <[email protected]>
Co-authored-by: amberhinds <[email protected]>
Co-authored-by: joedolson <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @t-hamano, I have reverted the changes and moved HTML element control to the Inspector advanced section. Please review it at your convenience.