gutenberg icon indicating copy to clipboard operation
gutenberg copied to clipboard

Move the `@wordpress/blocks` types defined in #48604 into own branch.

Open ryanwelcher opened this issue 1 year ago • 3 comments

What?

  • Part of https://github.com/WordPress/gutenberg/issues/67691.
  • Based on #48604.

This PR moves only the types from #48604 into a branch in this repo rather than in a fork. This is all of @johnhooks work with the exceptions of some small linting changes required to commit.

This branch can be merged into trunk or used as a feature branch to make small iterations to the package to introduce the types.

Why?

@johnhooks did a lot fantastic work defining the types and while the direction of that PR has changed, it would be a shame to lose that work as we move towards adding Typescript support to the blocks and block-editor packages.

Related: #39915

ryanwelcher avatar Dec 20 '24 20:12 ryanwelcher

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ryanwelcher <[email protected]>
Co-authored-by: tyxla <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] avatar Dec 20 '24 20:12 github-actions[bot]

Thanks for running the review @gziolo. I am hoping to pick this back up very soon

ryanwelcher avatar Jun 17 '25 18:06 ryanwelcher

Thanks for taking care of the continuity of this great work @ryanwelcher 👏

Since it's quite a large PR, can we make sure all checks are green before opening it for a formal review?

I've moved it to a draft for now.

ryanwelcher avatar Jun 17 '25 18:06 ryanwelcher