gutenberg icon indicating copy to clipboard operation
gutenberg copied to clipboard

Include arrows in pagination links

Open Takshil-Kunadia opened this issue 1 year ago • 4 comments

Fixes https://github.com/WordPress/gutenberg/issues/66040

What?

Including arrows markup when creating links.

Why?

Post navigation block arrow icon aren't clickable

How?

  • Create Arrows markup
  • Add arrows in navigation links markup according to the block attributes selected

Testing Instructions

  • Create a few posts.
  • Add Post Navigation pattern in the posts.
  • Try toggling including label and post title when arrows are enabled and see front end.

Testing Instructions for Keyboard

Screenshots or screencast

Before After

Takshil-Kunadia avatar Dec 04 '24 08:12 Takshil-Kunadia

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @jennajaehnig.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: jennajaehnig.

Co-authored-by: Takshil-Kunadia <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: AnmolVerma404 <[email protected]>
Co-authored-by: ariful93 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] avatar Dec 06 '24 05:12 github-actions[bot]

Thanks for contributing, @Takshil-Kunadia!

It looks like the referenced issue already has a PR - #67554.

Mamaduka avatar Jan 13 '25 16:01 Mamaduka

Thanks! @Mamaduka . I felt this PR provided a more complete solution. But do let me know if I should close it in favour of https://github.com/WordPress/gutenberg/pull/67554

Takshil-Kunadia avatar Jan 14 '25 07:01 Takshil-Kunadia

Thanks for the clarification, @Takshil-Kunadia!

Mamaduka avatar Jan 14 '25 07:01 Mamaduka