gutenberg icon indicating copy to clipboard operation
gutenberg copied to clipboard

Add radius foundation and tokens to storybook

Open jameskoster opened this issue 1 year ago • 3 comments

What?

Adds radius foundations and tokens to storybook.

Why?

  • Documenting the foundations creates an important point of reference for updating (or creating new) components and UIs.
  • Documenting the tokens makes them more discoverable.

Testing Instructions

  1. npm run storybook
  2. Check out the new pages; 'Foundations / Design Language / Radius' and 'Tokens / Radius'
Foundations page Tokens page
Screenshot 2024-10-17 at 18 30 56 Screenshot 2024-10-17 at 18 31 05

jameskoster avatar Oct 17 '24 17:10 jameskoster

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jameskoster <[email protected]>
Co-authored-by: ciampo <[email protected]>
Co-authored-by: tyxla <[email protected]>
Co-authored-by: jasmussen <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] avatar Oct 17 '24 17:10 github-actions[bot]

I think there's a question about the visual style we want to apply across these docs, it may be good to decide on a specific illustration style (which could be what you suggested, but it could also be this), and then roll it out consistently.

I think as a first draft this is fine. What do you think? Nice work.

jasmussen avatar Oct 18 '24 06:10 jasmussen

Rebased on top of latest changes, and pushed a couple of improvements / fixes.

In particular, I refactored the table so that it can be a more generic and work for both radius and elevation tokens. It's still a bit hacky, and we will definitely want to refine it (alongside other docs componentry)

ciampo avatar Oct 18 '24 12:10 ciampo

@tyxla Since I was the last one to work on this PR (and I'm not sure about Jay's availability this week), I've addressed the remaining feedback.

Will merge as soon as CI checks pass ✅

ciampo avatar Oct 24 '24 09:10 ciampo

Thanks @ciampo and @jameskoster 🙌

tyxla avatar Oct 24 '24 09:10 tyxla