gutenberg icon indicating copy to clipboard operation
gutenberg copied to clipboard

CircularOptionPicker: stop using composite store

Open ciampo opened this issue 5 months ago • 3 comments

What?

Requires #64832 to be merged first Extracted from #64723

Refactor CircularOptionPicker so that it doesn't use the store from useCompositeStore to function.

Why?

See https://github.com/WordPress/gutenberg/issues/63704#issuecomment-2305291168

How?

By controlling the activeId state via props.

Testing Instructions

Make sure that existing usages of CircularOptionPicker continue to work as expected.

In particular, make sure that, when CircularOptionPicker has a selected option (and the selected option is not the first option), tabbing on the component for the first time will automatically focus the selected option, instead of the first option.

ciampo avatar Aug 27 '24 14:08 ciampo