gutenberg icon indicating copy to clipboard operation
gutenberg copied to clipboard

Consider exposing the Font Library for classic themes

Open annezazu opened this issue 1 year ago • 10 comments

This has come up in a few places since the launch of the Font Library and, to ensure a dedicated focus for it, I wanted to open a standalone issue about bringing the font library to classic themes, separate from the overall Styles UI (issue here: https://github.com/WordPress/gutenberg/issues/41119). As previously noted, the font library was intentionally designed to be similar to the media library. The media library both is available as modal and a dedicated section of the admin interface, which sets a possible precedence for the font library too. In order to bring improved font management to classic themes, this issue seeks to explore what it might look like to bring the font library to classic themes.

annezazu avatar Aug 09 '24 21:08 annezazu

Here's a quick design that assumes this is mainly uploading and basic adding/removing/managing:

Classic fonts, basic

There's an open question on whether the Google Fonts library can easily be made available here. I'd love some technical feedback on that, CC: @matiasbenedetto. If it's possible/feasible/reasonable to embed the entire contents of the font library modal directly, perhaps it could be integrated like this:

Classic fonts, integrated

A more likely outcome, might be to simply make the modal available from the Appearance > Fonts menu item on the top level, like this:

Classic fonts, with modal

CC: @WordPress/gutenberg-design. Figma.

jasmussen avatar Aug 13 '24 12:08 jasmussen

What do you think of the method described here to use the font library in classic and hybrid themes?: https://wpdevelopment.courses/articles/font-library-classic-or-hybrid-themes/

matiasbenedetto avatar Aug 13 '24 13:08 matiasbenedetto

I think that can technically make it available, though it doesn't seem to address the spirit of this issue.

jasmussen avatar Aug 13 '24 13:08 jasmussen

I explored the idea of ​​exposing the Global Styles, including the Font Library, for the classic theme in this comment.

t-hamano avatar Aug 13 '24 13:08 t-hamano

Shared an update on https://github.com/WordPress/gutenberg/issues/41119#issuecomment-2328737652 which possibly enables a different approach to surfacing the font library for classic themes. Feel free to share your thoughts.

jasmussen avatar Sep 04 '24 11:09 jasmussen

For anyone following, some related conversation here.

jasmussen avatar Nov 13 '24 08:11 jasmussen

I think that exposing the Font Library to classic/hybrid themes would be a valuable enhancement. It would simplify typography management and create a more cohesive experience for theme developers. I hope that this feature is added in WP 6.8.

mrleemon avatar Jan 17 '25 11:01 mrleemon

What do you think of the method described here to use the font library in classic and hybrid themes?: https://wpdevelopment.courses/articles/font-library-classic-or-hybrid-themes/

This method unintentionally breaks blocks that rely on the Interactivity API.

mrleemon avatar Apr 21 '25 07:04 mrleemon

Would love to see this to make it into 7.0

Drivingralle avatar Dec 11 '25 15:12 Drivingralle

@Drivingralle PR #73876 has been recently committed.

mrleemon avatar Dec 11 '25 15:12 mrleemon

As of #73876, the Font Library is now available in hybrid themes (classic themes with theme.json).

I'm not sure if we can (or should) expose the Font Library to classic themes that don't have a theme.json. cc @youknowriad

t-hamano avatar Dec 12 '25 10:12 t-hamano

@t-hamano My opinion is that we should expose global styles and font library to classic themes. That said, before doing so, we need to ensure that exposing these don't break layouts of classic themes, so we might be missing some flags to "disable" things in theme.json or somethings like that.

youknowriad avatar Dec 12 '25 10:12 youknowriad