gutenberg icon indicating copy to clipboard operation
gutenberg copied to clipboard

Multi-entity save: reverse order of save and cancel buttons when saving in the frame

Open annezazu opened this issue 1 year ago • 4 comments

When saving changes in the frame rather than in the canvas, the order of the buttons should be reversed to make it more obvious to click the primary call to action ("save"). Generally, the primary action for items is often found on the right side.

Current:

Screenshot 2024-07-10 at 10 30 04 AM

Proposed

Screenshot 2024-07-10 at 10 35 47 AM

Of note, currently when saving in the canvas/editor, we show a similar order to the current and I wonder if we should also update there:

Screenshot 2024-07-10 at 10 36 55 AM

cc @WordPress/gutenberg-design for more context and thoughts.

annezazu avatar Jul 10 '24 17:07 annezazu

I would think both of these interfaces could use substantial design refreshes. But that shouldn't block this.

jasmussen avatar Jul 11 '24 07:07 jasmussen

I wonder if we should also update there

That will probably be necessary to avoid falling foul of a11y requirements (visual order should match DOM order).

jameskoster avatar Jul 11 '24 10:07 jameskoster

One note: if the save and cancel buttons are inverted in the second publish sidebar, when you press Save and the sidebar opens up, you'll press the cancel button almost immediately.

richtabor avatar Jul 16 '24 04:07 richtabor

One thing we could do, which I've seen discussed in other comments, is move the save/publish button almost all the way to the right:

Option

Figma.

jasmussen avatar Jul 16 '24 07:07 jasmussen

One thing we could do, which I've seen discussed in other comments, is move the save/publish button almost all the way to the right:

If we do, should the Inspector icon always be first next to it? So that it's consistently in the same place?

richtabor avatar Jul 17 '24 19:07 richtabor

Yes, like so, good catch:

jasmussen avatar Jul 31 '24 08:07 jasmussen

It looks like this one was resolved with https://github.com/WordPress/gutenberg/pull/65695 - I just tested it, and the order of the buttons is reversed. I'm closing this one; please feel free to open it if you think there's something else to do.

juanfra avatar Nov 08 '24 14:11 juanfra