gutenberg icon indicating copy to clipboard operation
gutenberg copied to clipboard

chore: convert escape-html package to typescript

Open jpstevens opened this issue 9 months ago • 1 comments

What?

This PR converts the escape-html package to TypeScript.

Why?

Ensures package is fully type checked.

How?

  • converted files to .ts
  • explicitly type functions and incorrectly-implied variables, based on @type, @param and @return comments

Testing Instructions

  • [x] npm run test:unit -- packages/escape-html tests pass
  • [ ] npm run build:package-types returns a zero exit code

jpstevens avatar May 13 '24 08:05 jpstevens

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jpstevens <[email protected]>
Co-authored-by: sirreal <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] avatar May 13 '24 08:05 github-actions[bot]

👋 @jpstevens Thanks for this! If you'll update this PR on the latest trunk and remove types from JSDoc, we can likely give this a final review and land it.

sirreal avatar Jun 13 '24 10:06 sirreal