gutenberg icon indicating copy to clipboard operation
gutenberg copied to clipboard

Fix: Post Template block: 'List view' display setting should be selected by default

Open hbhalodia opened this issue 1 year ago • 3 comments

Fixes https://github.com/WordPress/gutenberg/issues/61569

What?

  • Issue - https://github.com/WordPress/gutenberg/issues/61569

Why?

  • This PR adds the List View as default for the post template block.

How?

  • On checking, we identified that, Layout is coming as an attribute inside the post template block. We checked if that is undefined, set it as the default list view.

Testing Instructions

  • Open, any page.
  • Add the query loop block and select any pattern.
  • You would see now the list view is by default selected for that pattern.

Testing Instructions for Keyboard

  • NIL

Screenshots or screencast

Screenshot 2024-05-10 at 5 45 46 PM - You can see that, list type is selected by default.

hbhalodia avatar May 10 '24 12:05 hbhalodia

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

github-actions[bot] avatar May 10 '24 12:05 github-actions[bot]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: hbhalodia <[email protected]>
Co-authored-by: afercia <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] avatar May 10 '24 12:05 github-actions[bot]

Thanks for this PR @hbhalodia. Not my area of expertise but I'd investigate why the Post Template block doesn't have the layout attribute default in the block.json in the first place. Cc @tellthemachines I see relevant changes from https://github.com/WordPress/gutenberg/pull/49050 your eyes here would be appreciated 🙏🏽

afercia avatar May 13 '24 13:05 afercia