gutenberg icon indicating copy to clipboard operation
gutenberg copied to clipboard

Convert blob package to TypeScript

Open jpstevens opened this issue 9 months ago • 2 comments

What?

This PR converts the blob package to TypeScript.

Why?

Ensures package is fully type checked.

How?

  • converted files to .ts
  • explicitly typed variables and functions in index file
  • added @ts-ignore statements to tests that call functions in ways that are not type-compliant

Testing Instructions

npm run test:unit -- packages/blob tests pass npm run build:package-types returns a zero exit code

jpstevens avatar May 09 '24 19:05 jpstevens

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jpstevens <[email protected]>
Co-authored-by: jsnajdr <[email protected]>
Co-authored-by: sirreal <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] avatar May 09 '24 19:05 github-actions[bot]

:wave: Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @jpstevens! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

github-actions[bot] avatar May 09 '24 19:05 github-actions[bot]

👋 @jpstevens Thanks for this! If you'll update this PR on the latest trunk and address feedback we can likely give this a final review and land it.

sirreal avatar Jun 13 '24 10:06 sirreal