gutenberg icon indicating copy to clipboard operation
gutenberg copied to clipboard

Latest Posts: Fix video overflow in full content mode

Open amitraj2203 opened this issue 1 year ago • 2 comments

What?

Fixes: #61477

Why?

It makes videos contained within the allocated space in the latest posts block by setting appropriate width. Fixes overflow and overlap issues when 'Show full post' option is enabled, preventing horizontal scroll bars.

How?

Enqueues the styles for video, cover and media-text block in Latest Posts block,

Testing Instructions

  1. Add a latests posts block
  2. Enable "Post content > Show full post" in the block settings panel of the latests post block.

Testing Instructions for Keyboard

NIL

Screenshots or screencast

image
image

amitraj2203 avatar May 09 '24 17:05 amitraj2203

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: amitraj2203 <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] avatar May 09 '24 17:05 github-actions[bot]

Hi, thank you for the PR. The proposed change loads all the CSS for the video, cover and media & text blocks even when they are not on the page, including all the CSS that is unrelated to the width of the video. I think it would be more performant to only limit the width of the video as part of the CSS for the latest posts block.

carolinan avatar Jul 01 '24 04:07 carolinan