WordPress
Rollback most recent setup-node update
What?
This rolls back the most recent update to the actions/setup-node GitHub Action.
Why?
When using a Windows based runner, there are some failures occurring when the npm ci script is run.
See this workflow run associated with #61138.
How?
~This downgrades the actions/setup-node version from the latest (4.0.2) to 4.0.1, which fixes the problem in my testing (see #61288). It's not clear what's causing the problem, but it's likely related to the Windows related changes in 4.0.2 to add support for arm64.~
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Co-authored-by: desrosj <[email protected]>
Co-authored-by: DaniGuardiola <[email protected]>
Co-authored-by: sirreal <[email protected]>
Co-authored-by: kevin940726 <[email protected]>
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hmm, on second glance, this may not be fixing the issue. Reverting to draft to continue investigating.
Flaky tests detected in f21b053b2704af00a34c88f25fecd0e060a5d627. Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8913631643 📝 Reported issues:
- #48372 in
/test/e2e/specs/editor/various/inserting-blocks.spec.js
I'm honestly not sure what's going on now. This PR fully reverts #61211 now, and the issue is still present.
@kevin940726 do you have any ideas by chance? @DaniGuardiola did you find anything in your debugging on the other PR?
I'm in the process of debugging it, I'll report back when I either find something conclusive or... give up :)
Feel free to fully take over this and I will stop debugging on my branch. Seems like you were already able to get some useful insights, according to https://github.com/WordPress/gutenberg/pull/61138#issuecomment-2088688062
I was at a meetup so couldn't spend enough time here. Thank you for taking on this!
Heads up, I removed the logging stuff from my PR but somehow managed to not push it and it got merged 😅
https://github.com/WordPress/gutenberg/pull/61138/files#diff-bd14ee39f26ac8f8790a63a11c34e9e0f8ee8fe1e08f1d425c1874bc2f56e973
You should be able to simply override the trunk version with yours in this PR.
I've gone and merged the changes from trunk and updated the PR. Should be good for a review now!
Sorry, I forgot to change the PR title and brief description to reflect the new intent of this PR. @sirreal I think we've filtered out the failures elsewhere, but this just gives better log preservation for debug purposes.
I suspect the recent failures might be related to the node_modules cache we introduced in https://github.com/WordPress/gutenberg/pull/45932, but I don't have any theory backing the suspicion 😅. We can also try disabling caching node_modules on Windows and see if that fixes the issue.
