gutenberg icon indicating copy to clipboard operation
gutenberg copied to clipboard

Inserter: Pattern tab visibility

Open scruffian opened this issue 10 months ago • 3 comments

What problem does this address?

When there is no block selected the pattern tab doesn't show:

Steps to reproduce.

  1. Open the Site Editor.
  2. Open the Inserter > Patterns > Any category.
  3. Click on the canvas in Zoomed-out view.
  4. Notice that the Insert isn't closed, and the Patterns tab is missing.
  5. Toggle inserter.
  6. Notice that Media tab is also missing

What is your proposed solution?

I think the patterns tab should always be there but if you select a pattern and we don't know where it should go, we inform the user somehow.

scruffian avatar Apr 24 '24 09:04 scruffian

if you select a pattern and we don't know where it should go, we inform the user somehow.

A default result is better than an interruption, so always post at the start/end of sections list?

draganescu avatar Apr 24 '24 12:04 draganescu

We solved a connected issue in https://github.com/WordPress/gutenberg/pull/61002. However in that issue the problem was knowing which block to select when switching to zoomed out mode. This issue however is about what happens when blocks become deselected in zoomed out mode.

scruffian avatar Apr 25 '24 09:04 scruffian

Perhaps I'm misunderstanding, I'm not seeing this I think:

CleanShot 2024-05-01 at 10 49 28

richtabor avatar May 01 '24 14:05 richtabor

This issue is different now - we do show the patterns tab but it says this: Screenshot 2024-06-18 at 12 14 18

This is fine at the moment, but when we move to leaving the inserter always open I wonder if we'll need better messaging here?

scruffian avatar Jun 18 '24 11:06 scruffian

Is this still relevant? I'm seeing this here on trunk:

https://github.com/user-attachments/assets/4e549ab2-55e1-47e3-9355-190b93cfa4d3

richtabor avatar Jul 13 '24 00:07 richtabor

Try selecting a button block: Screenshot 2024-07-19 at 13 44 03

scruffian avatar Jul 19 '24 12:07 scruffian

Closing in favour of https://github.com/WordPress/gutenberg/issues/61320

scruffian avatar Jul 22 '24 08:07 scruffian