gutenberg
gutenberg copied to clipboard
WordPress
Project: Remove Puppeteer
What?
Now that Playwright migration is completed, we can safely remove Puppeteer and related.
Testing Instructions
CI should be green.
I think this needs to become a peer dependency just like Playwright. @swissspidy, @gziolo what do you think?
https://github.com/WordPress/gutenberg/blob/8ce1a6cc74afcba5a49f39cc08883a850f112a4d/packages/scripts/package.json#L79
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: ellatrix <[email protected]>
Co-authored-by: talldan <[email protected]>
Co-authored-by: gziolo <[email protected]>
Co-authored-by: youknowriad <[email protected]>
Co-authored-by: ntsekouras <[email protected]>
Co-authored-by: kevin940726 <[email protected]>
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
I think this needs to become a peer dependency just like Playwright. @swissspidy, @gziolo what do you think?
https://github.com/WordPress/gutenberg/blob/8ce1a6cc74afcba5a49f39cc08883a850f112a4d/packages/scripts/package.json#L79
As long as it works when using @wordpress/scripts alone which it should, it's fine with me.
@Mamaduka can we remove the npm dependency entirely since we now recommend playwright, It can be a breaking change in the wp-scripts package but that seems fine.
Is this all that needs to be removed? What about the e2e-tests package?
First we’ll need to relocate test plugins in different directory and then I guess deprecate the package. Not sure what’s the policy about that.
First we’ll need to relocate test plugins in different directory and then I guess deprecate the package. Not sure what’s the policy about that.
I think @wordpress/nux is a package that has been deprecated in the past. There was also an attempt to remove it in the past which didn't go so well as it's used by core. This one might be different as it's only a dev dependency. 🤔
@Mamaduka can we remove the npm dependency entirely since we now recommend playwright, It can be a breaking change in the wp-scripts package but that seems fine.
➕ to this.
Another smaller thing is that we can now reference npm run test:e2e directly to npm run test:e2e:playwright in this repo. We can keep the test:e2e:playwright script for a while for muscle memory.
Good point, @talldan!
I'll create a separate issue to remove Puppeteer from the scripts package. We can discuss the best options there.
Flaky tests detected in 34b004e790429b978b16bae2c506fdeaa6bae6cf. Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8519245299 📝 Reported issues:
- #59579 in
/test/e2e/specs/editor/various/multi-block-selection.spec.js