gutenberg icon indicating copy to clipboard operation
gutenberg copied to clipboard
verified publisher icon WordPress

Button: Replace deprecated isSmall property with size="small" property

Open t-hamano opened this issue 2 years ago • 2 comments

Related to #53472

The deprecated isSmall property is being used in the Button component and in the component that wraps the Button component.

I believe that the isSmall property should be replaced with size="prop" to officially deprecate it, as mentioned in this comment.

button-deprecated

t-hamano avatar Aug 11 '23 07:08 t-hamano

Note isSmall is used in several other places and there's a PR to fix it at https://github.com/WordPress/gutenberg/pull/53599

skorasaurus avatar Nov 03 '23 18:11 skorasaurus

I can see there are more instances still. So reopening

fabiankaegy avatar Feb 23 '24 07:02 fabiankaegy

I'm taking on this one.

jaclync avatar Mar 07 '24 06:03 jaclync

For future contributors, the remaining components to replace that I found:

  • [ ] SidesDropdown
  • [ ] PaletteEdit
  • [ ] ToolsPanelHeader

jaclync avatar Mar 07 '24 07:03 jaclync

Once #59302 is merged, all isSmall props will be replaced and this issue can be closed. Thank you to everyone who worked on this issue!

t-hamano avatar Mar 07 '24 09:03 t-hamano