gutenberg
gutenberg copied to clipboard
WordPress
Move view site button next to site title
What?
An alternative at the placement of the external link within the site hub.
Other follow-ups could be to make the site title a link itself, and perhaps reduce the externalLink icon to only show up when hovering the site title itself.
Testing Instructions
- Open the Site Editor.
- Hover over the site hub area.
- See changes.
Screenshots or screencast
Before:
https://github.com/WordPress/gutenberg/assets/1813435/7718141e-8a02-4651-92fd-6e70e40df888
After:
https://github.com/WordPress/gutenberg/assets/1813435/91796453-a5ab-401e-9b28-d0dfff4650c8
Size Change: +11 B (0%)
Total Size: 1.44 MB
| Filename | Size | Change |
|---|---|---|
build/edit-site/index.min.js |
82.8 kB | +1 B (0%) |
build/edit-site/style-rtl.css |
12.5 kB | +5 B (0%) |
build/edit-site/style.css |
12.5 kB | +5 B (0%) |
ℹ️ View Unchanged
| Filename | Size |
|---|---|
build/a11y/index.min.js |
955 B |
build/annotations/index.min.js |
2.69 kB |
build/api-fetch/index.min.js |
2.28 kB |
build/autop/index.min.js |
2.1 kB |
build/blob/index.min.js |
451 B |
build/block-directory/index.min.js |
6.99 kB |
build/block-directory/style-rtl.css |
1.02 kB |
build/block-directory/style.css |
1.02 kB |
build/block-editor/content-rtl.css |
4.22 kB |
build/block-editor/content.css |
4.22 kB |
build/block-editor/default-editor-styles-rtl.css |
381 B |
build/block-editor/default-editor-styles.css |
381 B |
build/block-editor/index.min.js |
208 kB |
build/block-editor/style-rtl.css |
14.7 kB |
build/block-editor/style.css |
14.7 kB |
build/block-library/blocks/archives/editor-rtl.css |
61 B |
build/block-library/blocks/archives/editor.css |
60 B |
build/block-library/blocks/archives/style-rtl.css |
90 B |
build/block-library/blocks/archives/style.css |
90 B |
build/block-library/blocks/audio/editor-rtl.css |
150 B |
build/block-library/blocks/audio/editor.css |
150 B |
build/block-library/blocks/audio/style-rtl.css |
122 B |
build/block-library/blocks/audio/style.css |
122 B |
build/block-library/blocks/audio/theme-rtl.css |
126 B |
build/block-library/blocks/audio/theme.css |
126 B |
build/block-library/blocks/avatar/editor-rtl.css |
116 B |
build/block-library/blocks/avatar/editor.css |
116 B |
build/block-library/blocks/avatar/style-rtl.css |
104 B |
build/block-library/blocks/avatar/style.css |
104 B |
build/block-library/blocks/block/editor-rtl.css |
305 B |
build/block-library/blocks/block/editor.css |
305 B |
build/block-library/blocks/button/editor-rtl.css |
584 B |
build/block-library/blocks/button/editor.css |
582 B |
build/block-library/blocks/button/style-rtl.css |
624 B |
build/block-library/blocks/button/style.css |
623 B |
build/block-library/blocks/buttons/editor-rtl.css |
337 B |
build/block-library/blocks/buttons/editor.css |
337 B |
build/block-library/blocks/buttons/style-rtl.css |
332 B |
build/block-library/blocks/buttons/style.css |
332 B |
build/block-library/blocks/calendar/style-rtl.css |
239 B |
build/block-library/blocks/calendar/style.css |
239 B |
build/block-library/blocks/categories/editor-rtl.css |
113 B |
build/block-library/blocks/categories/editor.css |
112 B |
build/block-library/blocks/categories/style-rtl.css |
124 B |
build/block-library/blocks/categories/style.css |
124 B |
build/block-library/blocks/code/editor-rtl.css |
53 B |
build/block-library/blocks/code/editor.css |
53 B |
build/block-library/blocks/code/style-rtl.css |
121 B |
build/block-library/blocks/code/style.css |
121 B |
build/block-library/blocks/code/theme-rtl.css |
124 B |
build/block-library/blocks/code/theme.css |
124 B |
build/block-library/blocks/columns/editor-rtl.css |
108 B |
build/block-library/blocks/columns/editor.css |
108 B |
build/block-library/blocks/columns/style-rtl.css |
409 B |
build/block-library/blocks/columns/style.css |
409 B |
build/block-library/blocks/comment-author-avatar/editor-rtl.css |
125 B |
build/block-library/blocks/comment-author-avatar/editor.css |
125 B |
build/block-library/blocks/comment-content/style-rtl.css |
92 B |
build/block-library/blocks/comment-content/style.css |
92 B |
build/block-library/blocks/comment-template/style-rtl.css |
199 B |
build/block-library/blocks/comment-template/style.css |
198 B |
build/block-library/blocks/comments-pagination-numbers/editor-rtl.css |
123 B |
build/block-library/blocks/comments-pagination-numbers/editor.css |
121 B |
build/block-library/blocks/comments-pagination/editor-rtl.css |
222 B |
build/block-library/blocks/comments-pagination/editor.css |
209 B |
build/block-library/blocks/comments-pagination/style-rtl.css |
235 B |
build/block-library/blocks/comments-pagination/style.css |
231 B |
build/block-library/blocks/comments-title/editor-rtl.css |
75 B |
build/block-library/blocks/comments-title/editor.css |
75 B |
build/block-library/blocks/comments/editor-rtl.css |
840 B |
build/block-library/blocks/comments/editor.css |
839 B |
build/block-library/blocks/comments/style-rtl.css |
637 B |
build/block-library/blocks/comments/style.css |
636 B |
build/block-library/blocks/cover/editor-rtl.css |
647 B |
build/block-library/blocks/cover/editor.css |
650 B |
build/block-library/blocks/cover/style-rtl.css |
1.61 kB |
build/block-library/blocks/cover/style.css |
1.6 kB |
build/block-library/blocks/details/editor-rtl.css |
65 B |
build/block-library/blocks/details/editor.css |
65 B |
build/block-library/blocks/details/style-rtl.css |
159 B |
build/block-library/blocks/details/style.css |
159 B |
build/block-library/blocks/embed/editor-rtl.css |
293 B |
build/block-library/blocks/embed/editor.css |
293 B |
build/block-library/blocks/embed/style-rtl.css |
410 B |
build/block-library/blocks/embed/style.css |
410 B |
build/block-library/blocks/embed/theme-rtl.css |
126 B |
build/block-library/blocks/embed/theme.css |
126 B |
build/block-library/blocks/file/editor-rtl.css |
316 B |
build/block-library/blocks/file/editor.css |
316 B |
build/block-library/blocks/file/interactivity.min.js |
395 B |
build/block-library/blocks/file/style-rtl.css |
269 B |
build/block-library/blocks/file/style.css |
270 B |
build/block-library/blocks/file/view.min.js |
375 B |
build/block-library/blocks/footnotes/style-rtl.css |
183 B |
build/block-library/blocks/footnotes/style.css |
182 B |
build/block-library/blocks/freeform/editor-rtl.css |
2.58 kB |
build/block-library/blocks/freeform/editor.css |
2.58 kB |
build/block-library/blocks/gallery/editor-rtl.css |
947 B |
build/block-library/blocks/gallery/editor.css |
952 B |
build/block-library/blocks/gallery/style-rtl.css |
1.53 kB |
build/block-library/blocks/gallery/style.css |
1.53 kB |
build/block-library/blocks/gallery/theme-rtl.css |
108 B |
build/block-library/blocks/gallery/theme.css |
108 B |
build/block-library/blocks/group/editor-rtl.css |
654 B |
build/block-library/blocks/group/editor.css |
654 B |
build/block-library/blocks/group/style-rtl.css |
57 B |
build/block-library/blocks/group/style.css |
57 B |
build/block-library/blocks/group/theme-rtl.css |
78 B |
build/block-library/blocks/group/theme.css |
78 B |
build/block-library/blocks/heading/style-rtl.css |
76 B |
build/block-library/blocks/heading/style.css |
76 B |
build/block-library/blocks/html/editor-rtl.css |
336 B |
build/block-library/blocks/html/editor.css |
337 B |
build/block-library/blocks/image/editor-rtl.css |
834 B |
build/block-library/blocks/image/editor.css |
833 B |
build/block-library/blocks/image/interactivity.min.js |
1.34 kB |
build/block-library/blocks/image/style-rtl.css |
1.34 kB |
build/block-library/blocks/image/style.css |
1.34 kB |
build/block-library/blocks/image/theme-rtl.css |
126 B |
build/block-library/blocks/image/theme.css |
126 B |
build/block-library/blocks/latest-comments/style-rtl.css |
357 B |
build/block-library/blocks/latest-comments/style.css |
357 B |
build/block-library/blocks/latest-posts/editor-rtl.css |
213 B |
build/block-library/blocks/latest-posts/editor.css |
212 B |
build/block-library/blocks/latest-posts/style-rtl.css |
478 B |
build/block-library/blocks/latest-posts/style.css |
478 B |
build/block-library/blocks/list/style-rtl.css |
88 B |
build/block-library/blocks/list/style.css |
88 B |
build/block-library/blocks/media-text/editor-rtl.css |
266 B |
build/block-library/blocks/media-text/editor.css |
263 B |
build/block-library/blocks/media-text/style-rtl.css |
507 B |
build/block-library/blocks/media-text/style.css |
505 B |
build/block-library/blocks/more/editor-rtl.css |
431 B |
build/block-library/blocks/more/editor.css |
431 B |
build/block-library/blocks/navigation-link/editor-rtl.css |
712 B |
build/block-library/blocks/navigation-link/editor.css |
711 B |
build/block-library/blocks/navigation-link/style-rtl.css |
115 B |
build/block-library/blocks/navigation-link/style.css |
115 B |
build/block-library/blocks/navigation-submenu/editor-rtl.css |
296 B |
build/block-library/blocks/navigation-submenu/editor.css |
295 B |
build/block-library/blocks/navigation/editor-rtl.css |
2.26 kB |
build/block-library/blocks/navigation/editor.css |
2.26 kB |
build/block-library/blocks/navigation/interactivity.min.js |
978 B |
build/block-library/blocks/navigation/style-rtl.css |
2.21 kB |
build/block-library/blocks/navigation/style.css |
2.2 kB |
build/block-library/blocks/navigation/view-modal.min.js |
2.78 kB |
build/block-library/blocks/navigation/view.min.js |
438 B |
build/block-library/blocks/nextpage/editor-rtl.css |
395 B |
build/block-library/blocks/nextpage/editor.css |
395 B |
build/block-library/blocks/page-list/editor-rtl.css |
401 B |
build/block-library/blocks/page-list/editor.css |
401 B |
build/block-library/blocks/page-list/style-rtl.css |
175 B |
build/block-library/blocks/page-list/style.css |
175 B |
build/block-library/blocks/paragraph/editor-rtl.css |
174 B |
build/block-library/blocks/paragraph/editor.css |
174 B |
build/block-library/blocks/paragraph/style-rtl.css |
279 B |
build/block-library/blocks/paragraph/style.css |
281 B |
build/block-library/blocks/post-author/style-rtl.css |
175 B |
build/block-library/blocks/post-author/style.css |
176 B |
build/block-library/blocks/post-comments-form/editor-rtl.css |
96 B |
build/block-library/blocks/post-comments-form/editor.css |
96 B |
build/block-library/blocks/post-comments-form/style-rtl.css |
508 B |
build/block-library/blocks/post-comments-form/style.css |
508 B |
build/block-library/blocks/post-date/style-rtl.css |
61 B |
build/block-library/blocks/post-date/style.css |
61 B |
build/block-library/blocks/post-excerpt/editor-rtl.css |
71 B |
build/block-library/blocks/post-excerpt/editor.css |
71 B |
build/block-library/blocks/post-excerpt/style-rtl.css |
141 B |
build/block-library/blocks/post-excerpt/style.css |
141 B |
build/block-library/blocks/post-featured-image/editor-rtl.css |
588 B |
build/block-library/blocks/post-featured-image/editor.css |
586 B |
build/block-library/blocks/post-featured-image/style-rtl.css |
319 B |
build/block-library/blocks/post-featured-image/style.css |
319 B |
build/block-library/blocks/post-navigation-link/style-rtl.css |
153 B |
build/block-library/blocks/post-navigation-link/style.css |
153 B |
build/block-library/blocks/post-template/editor-rtl.css |
99 B |
build/block-library/blocks/post-template/editor.css |
98 B |
build/block-library/blocks/post-template/style-rtl.css |
314 B |
build/block-library/blocks/post-template/style.css |
314 B |
build/block-library/blocks/post-terms/style-rtl.css |
96 B |
build/block-library/blocks/post-terms/style.css |
96 B |
build/block-library/blocks/post-time-to-read/style-rtl.css |
69 B |
build/block-library/blocks/post-time-to-read/style.css |
69 B |
build/block-library/blocks/post-title/style-rtl.css |
100 B |
build/block-library/blocks/post-title/style.css |
100 B |
build/block-library/blocks/preformatted/style-rtl.css |
103 B |
build/block-library/blocks/preformatted/style.css |
103 B |
build/block-library/blocks/pullquote/editor-rtl.css |
135 B |
build/block-library/blocks/pullquote/editor.css |
135 B |
build/block-library/blocks/pullquote/style-rtl.css |
335 B |
build/block-library/blocks/pullquote/style.css |
335 B |
build/block-library/blocks/pullquote/theme-rtl.css |
167 B |
build/block-library/blocks/pullquote/theme.css |
167 B |
build/block-library/blocks/query-pagination-numbers/editor-rtl.css |
122 B |
build/block-library/blocks/query-pagination-numbers/editor.css |
121 B |
build/block-library/blocks/query-pagination/editor-rtl.css |
221 B |
build/block-library/blocks/query-pagination/editor.css |
211 B |
build/block-library/blocks/query-pagination/style-rtl.css |
288 B |
build/block-library/blocks/query-pagination/style.css |
284 B |
build/block-library/blocks/query-title/style-rtl.css |
63 B |
build/block-library/blocks/query-title/style.css |
63 B |
build/block-library/blocks/query/editor-rtl.css |
450 B |
build/block-library/blocks/query/editor.css |
449 B |
build/block-library/blocks/quote/style-rtl.css |
222 B |
build/block-library/blocks/quote/style.css |
222 B |
build/block-library/blocks/quote/theme-rtl.css |
223 B |
build/block-library/blocks/quote/theme.css |
226 B |
build/block-library/blocks/read-more/style-rtl.css |
132 B |
build/block-library/blocks/read-more/style.css |
132 B |
build/block-library/blocks/rss/editor-rtl.css |
149 B |
build/block-library/blocks/rss/editor.css |
149 B |
build/block-library/blocks/rss/style-rtl.css |
289 B |
build/block-library/blocks/rss/style.css |
288 B |
build/block-library/blocks/search/editor-rtl.css |
178 B |
build/block-library/blocks/search/editor.css |
178 B |
build/block-library/blocks/search/style-rtl.css |
587 B |
build/block-library/blocks/search/style.css |
584 B |
build/block-library/blocks/search/theme-rtl.css |
114 B |
build/block-library/blocks/search/theme.css |
114 B |
build/block-library/blocks/search/view.min.js |
531 B |
build/block-library/blocks/separator/editor-rtl.css |
146 B |
build/block-library/blocks/separator/editor.css |
146 B |
build/block-library/blocks/separator/style-rtl.css |
234 B |
build/block-library/blocks/separator/style.css |
234 B |
build/block-library/blocks/separator/theme-rtl.css |
194 B |
build/block-library/blocks/separator/theme.css |
194 B |
build/block-library/blocks/shortcode/editor-rtl.css |
323 B |
build/block-library/blocks/shortcode/editor.css |
323 B |
build/block-library/blocks/site-logo/editor-rtl.css |
754 B |
build/block-library/blocks/site-logo/editor.css |
754 B |
build/block-library/blocks/site-logo/style-rtl.css |
203 B |
build/block-library/blocks/site-logo/style.css |
203 B |
build/block-library/blocks/site-tagline/editor-rtl.css |
86 B |
build/block-library/blocks/site-tagline/editor.css |
86 B |
build/block-library/blocks/site-title/editor-rtl.css |
116 B |
build/block-library/blocks/site-title/editor.css |
116 B |
build/block-library/blocks/site-title/style-rtl.css |
57 B |
build/block-library/blocks/site-title/style.css |
57 B |
build/block-library/blocks/social-link/editor-rtl.css |
184 B |
build/block-library/blocks/social-link/editor.css |
184 B |
build/block-library/blocks/social-links/editor-rtl.css |
674 B |
build/block-library/blocks/social-links/editor.css |
673 B |
build/block-library/blocks/social-links/style-rtl.css |
1.43 kB |
build/block-library/blocks/social-links/style.css |
1.42 kB |
build/block-library/blocks/spacer/editor-rtl.css |
348 B |
build/block-library/blocks/spacer/editor.css |
348 B |
build/block-library/blocks/spacer/style-rtl.css |
48 B |
build/block-library/blocks/spacer/style.css |
48 B |
build/block-library/blocks/table/editor-rtl.css |
433 B |
build/block-library/blocks/table/editor.css |
433 B |
build/block-library/blocks/table/style-rtl.css |
645 B |
build/block-library/blocks/table/style.css |
644 B |
build/block-library/blocks/table/theme-rtl.css |
146 B |
build/block-library/blocks/table/theme.css |
146 B |
build/block-library/blocks/tag-cloud/style-rtl.css |
251 B |
build/block-library/blocks/tag-cloud/style.css |
253 B |
build/block-library/blocks/template-part/editor-rtl.css |
403 B |
build/block-library/blocks/template-part/editor.css |
403 B |
build/block-library/blocks/template-part/theme-rtl.css |
101 B |
build/block-library/blocks/template-part/theme.css |
101 B |
build/block-library/blocks/term-description/style-rtl.css |
111 B |
build/block-library/blocks/term-description/style.css |
111 B |
build/block-library/blocks/text-columns/editor-rtl.css |
95 B |
build/block-library/blocks/text-columns/editor.css |
95 B |
build/block-library/blocks/text-columns/style-rtl.css |
166 B |
build/block-library/blocks/text-columns/style.css |
166 B |
build/block-library/blocks/verse/style-rtl.css |
99 B |
build/block-library/blocks/verse/style.css |
99 B |
build/block-library/blocks/video/editor-rtl.css |
552 B |
build/block-library/blocks/video/editor.css |
555 B |
build/block-library/blocks/video/style-rtl.css |
174 B |
build/block-library/blocks/video/style.css |
174 B |
build/block-library/blocks/video/theme-rtl.css |
126 B |
build/block-library/blocks/video/theme.css |
126 B |
build/block-library/classic-rtl.css |
179 B |
build/block-library/classic.css |
179 B |
build/block-library/common-rtl.css |
1.1 kB |
build/block-library/common.css |
1.1 kB |
build/block-library/editor-elements-rtl.css |
75 B |
build/block-library/editor-elements.css |
75 B |
build/block-library/editor-rtl.css |
12.1 kB |
build/block-library/editor.css |
12.1 kB |
build/block-library/elements-rtl.css |
54 B |
build/block-library/elements.css |
54 B |
build/block-library/index.min.js |
201 kB |
build/block-library/interactivity/runtime.min.js |
2.69 kB |
build/block-library/interactivity/vendors.min.js |
8.2 kB |
build/block-library/reset-rtl.css |
478 B |
build/block-library/reset.css |
478 B |
build/block-library/style-rtl.css |
13.6 kB |
build/block-library/style.css |
13.6 kB |
build/block-library/theme-rtl.css |
686 B |
build/block-library/theme.css |
691 B |
build/block-serialization-default-parser/index.min.js |
1.12 kB |
build/block-serialization-spec-parser/index.min.js |
2.87 kB |
build/blocks/index.min.js |
50.9 kB |
build/commands/index.min.js |
14.9 kB |
build/commands/style-rtl.css |
827 B |
build/commands/style.css |
827 B |
build/components/index.min.js |
240 kB |
build/components/style-rtl.css |
11.8 kB |
build/components/style.css |
11.8 kB |
build/compose/index.min.js |
12 kB |
build/core-commands/index.min.js |
2.12 kB |
build/core-data/index.min.js |
16.1 kB |
build/customize-widgets/index.min.js |
11.9 kB |
build/customize-widgets/style-rtl.css |
1.46 kB |
build/customize-widgets/style.css |
1.45 kB |
build/data-controls/index.min.js |
640 B |
build/data/index.min.js |
8.25 kB |
build/date/index.min.js |
40.4 kB |
build/deprecated/index.min.js |
451 B |
build/dom-ready/index.min.js |
324 B |
build/dom/index.min.js |
4.63 kB |
build/edit-post/classic-rtl.css |
544 B |
build/edit-post/classic.css |
545 B |
build/edit-post/index.min.js |
33.9 kB |
build/edit-post/style-rtl.css |
7.58 kB |
build/edit-post/style.css |
7.57 kB |
build/edit-widgets/index.min.js |
16.8 kB |
build/edit-widgets/style-rtl.css |
4.53 kB |
build/edit-widgets/style.css |
4.53 kB |
build/editor/index.min.js |
45.5 kB |
build/editor/style-rtl.css |
3.58 kB |
build/editor/style.css |
3.58 kB |
build/element/index.min.js |
4.8 kB |
build/escape-html/index.min.js |
537 B |
build/format-library/index.min.js |
7.62 kB |
build/format-library/style-rtl.css |
554 B |
build/format-library/style.css |
553 B |
build/hooks/index.min.js |
1.55 kB |
build/html-entities/index.min.js |
448 B |
build/i18n/index.min.js |
3.58 kB |
build/is-shallow-equal/index.min.js |
527 B |
build/keyboard-shortcuts/index.min.js |
1.64 kB |
build/keycodes/index.min.js |
1.84 kB |
build/list-reusable-blocks/index.min.js |
2.13 kB |
build/list-reusable-blocks/style-rtl.css |
836 B |
build/list-reusable-blocks/style.css |
836 B |
build/media-utils/index.min.js |
2.9 kB |
build/notices/index.min.js |
948 B |
build/plugins/index.min.js |
1.77 kB |
build/preferences-persistence/index.min.js |
1.84 kB |
build/preferences/index.min.js |
1.24 kB |
build/primitives/index.min.js |
943 B |
build/priority-queue/index.min.js |
1.52 kB |
build/private-apis/index.min.js |
943 B |
build/react-i18n/index.min.js |
615 B |
build/react-refresh-entry/index.min.js |
8.44 kB |
build/react-refresh-runtime/index.min.js |
7.31 kB |
build/redux-routine/index.min.js |
2.7 kB |
build/reusable-blocks/index.min.js |
2.38 kB |
build/reusable-blocks/style-rtl.css |
243 B |
build/reusable-blocks/style.css |
243 B |
build/rich-text/index.min.js |
10.9 kB |
build/router/index.min.js |
1.77 kB |
build/server-side-render/index.min.js |
1.94 kB |
build/shortcode/index.min.js |
1.39 kB |
build/style-engine/index.min.js |
1.81 kB |
build/token-list/index.min.js |
582 B |
build/url/index.min.js |
3.57 kB |
build/vendors/inert-polyfill.min.js |
2.48 kB |
build/vendors/react-dom.min.js |
41.8 kB |
build/vendors/react.min.js |
4.02 kB |
build/viewport/index.min.js |
958 B |
build/warning/index.min.js |
268 B |
build/widgets/index.min.js |
7.16 kB |
build/widgets/style-rtl.css |
1.15 kB |
build/widgets/style.css |
1.16 kB |
build/wordcount/index.min.js |
1.02 kB |
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Good one!
Thanks @paaljoachim!
Let's hold on a merge for a bit though; I would like to get additional feedback before pushing it in.
Yep, that makes sense to me, though if we do this I'd reduce the size of the icon similar to how we do in other places. You can even underline the title to indicate it's a link:
I think the only open question we need to answer is: do we eventually expect site logo + site title to be one big clickable area to go back to the top level admin? If yes, then this would probably not be a good change.
If we expect it to always be only the site logo/icon, then this change is fine. I lean towards this assessment myself.
In the latest Gutenberg, View Site link is always visible and the position has been adjusted slightly.
- #57423
- #60511
Is this PR still valid for the current Gutenberg trunk?
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Co-authored-by: richtabor <[email protected]>
Co-authored-by: paaljoachim <[email protected]>
Co-authored-by: jasmussen <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: jameskoster <[email protected]>
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
Can work. Not sure it's better, the big external link icon feels like an icon button that should sit on the right next to other icon buttons.
Separately, I have a feeling lots of sites "in the wild" have very long titles. In fact trunk at the moment doesn't handle this too well:
It's possible MacRumors uses the tagline to contextually show the verbose description, but the possibility of very long titles remains.
How this is handled is something good to consider. Would the external link bump up against the loupe and stay put, causing the title to wrap from that point on? Would the text be elided?
If the need is to free up that space for another icon button, another option is this. Resting state:
Hover state:
That would change the icon button to a glyph and feel part of the title instead.
I'd echo Joen; it seems sensible to do one or the other:
- Site title is not a link, icon button remains in current position
- Site title becomes a link with ↗ on hover
Iirc, when this was initially implemented the argument against making the title a link was; it might end up feeling like a label for the site icon button, and that the two elements having different behaviours could be unexpected. I don't have a strong feeling about that personally, but wanted to raise it as a valid concern. Separate hover effects for each could help mitigate any confusion there.
Site title becomes a link with ↗ on hover
#60885 was submitted to display a fallback URL when the site title does not exist. Once this is merged, the site title text is guaranteed to always be visible, so the above approach should be fine.
We have this in the admin bar today. I think we can do the same in the Site Editor (sans home icon), using the site name as the link and showing the glyph on hover.
@jasmussen What do you think of this?
https://github.com/WordPress/gutenberg/assets/1813435/a0378d64-1acc-4d92-86c9-e21103af3b9a
I spun up https://github.com/WordPress/gutenberg/pull/61258 to explore as this effort is quite old.
I'll close this in favor of https://github.com/WordPress/gutenberg/pull/61258 then.