gutenberg icon indicating copy to clipboard operation
gutenberg copied to clipboard

Block inserter lacking a clear close button

Open getdave opened this issue 3 years ago • 8 comments

As reported in https://github.com/WordPress/gutenberg/issues/46939#issuecomment-1374652632 the block inserter is lacking a clear close button. This makes it very difficult for users of assistive technology to exist the popover.

A clear button should be provided which closes the inserter and returns focus to the last focused element.

getdave avatar Jan 10 '23 11:01 getdave

This seems to be a feature request for the quick inserter.

draganescu avatar Jan 10 '23 21:01 draganescu

Yes but a must none the less. Not sure how I missed this elsewhere. Maybe I just never used it anywhere else before now. Escape is not a given sadly so having a close button makes it clear.

alexstine avatar Jan 13 '23 03:01 alexstine

I think this needs some design guidance before it can be implemented.

carolinan avatar Jan 19 '23 07:01 carolinan

Related to a conversation here, I'd like to hear thoughts on having it be an on-focus close button that appears, for example, at the end of the list of tabbables.

jasmussen avatar Jan 20 '23 09:01 jasmussen

As @jasmussen suggests, could we add a visually hidden button that can be focused via keyboard navigation? The button could become visually visible when focused, similarly to the "skip to content" links that are usually added at the top of a web page.

ciampo avatar Jan 20 '23 10:01 ciampo

I implemented a proof of concept in https://github.com/WordPress/gutenberg/pull/47327

getdave avatar Jan 21 '23 07:01 getdave

Screen Shot 2023-01-30 at 10 18 14 (1)

Here's an example of where we already include a clear Close button in the UI. I wonder whether would could borrow the same pattern?

getdave avatar Jan 30 '23 10:01 getdave

I think having the design feedback label makes sense. I am not sure this also needs design, so for now going to focus back on that label.

karmatosed avatar May 31 '25 14:05 karmatosed