gutenberg
gutenberg copied to clipboard
WordPress
Add unit test for post title block render function
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.
If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
Co-authored-by: akasunil <[email protected]>
Co-authored-by: draganescu <[email protected]>
Co-authored-by: spacedmonkey <[email protected]>
Co-authored-by: anton-vlasenko <[email protected]>
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Could the test file be renamed to
renderBlockCorePostTitle.php?
Is this the new standards that we are going to follow from now on for test file name? because all other files are named in kebab-case.
Could the test file be renamed to
renderBlockCorePostTitle.php?Is this the new standards that we are going to follow from now on for test file name? because all other files are named in kebab-case.
No, this is not a new standard, but I agree, it might seem new. There are (mostly) old tests that don't follow this naming convention, and the newer ones that adhere to it, e.g.: https://github.com/WordPress/wordpress-develop/tree/trunk/tests/phpunit/tests/option
@anton-vlasenko To follow the standard for file name of unit tests, It required to update phpunit config file first.
I have updated phpunit config temporary until we change all filenames to camel case as per wordpress core standard. And Addressed all feedback provided by reviewer.