gutenberg icon indicating copy to clipboard operation
gutenberg copied to clipboard

Make it possible to edit template part properties in focus mode

Open jameskoster opened this issue 4 years ago • 7 comments

When a template part is selected in the template editing view it's possible to edit its properties like area in the Advanced panel:

Screenshot 2021-12-08 at 10 57 27

It should also be possible to manage these properties whilst editing a tempalte part in focus mode. Perhaps in the currently-empty Template tab:

Screenshot 2021-12-08 at 10 58 23

Or the template details popover:

Screenshot 2021-12-08 at 10 59 40

jameskoster avatar Dec 08 '21 11:12 jameskoster

I like the idea of the template tab but my concern is we are heading to multiple places for information. I get the desire to access important things, but you don't need access to everything in all places, so working out the interaction paths is key here and use cases.

karmatosed avatar Jan 07 '22 19:01 karmatosed

For me it's more a question of appropriate hierarchy. For example I don't know that it should be necessary to enter template part focus mode to change a template part properties, that could lead to some frustrating UX. So placing those options in the Advanced panel seems sensible.

But since focus mode feels like the primary template part editing interface, it seems logical that fundamental properties like the name should be editable there too.

jameskoster avatar Jan 10 '22 11:01 jameskoster

In light of discussions elsewhere it might make sense to put these controls in the top toolbar, with a view removing the sad and empty "Template" tab from the insepctor.

Editing a post Editing a Template Part
Screenshot 2022-05-12 at 14 27 31 Screenshot 2022-05-12 at 14 27 46

If we need a short-term solution, it would probably be fine to put these controls (area / html element) in the Inspector.

jameskoster avatar May 12 '22 13:05 jameskoster

Noting that this came up with the recent FSE Outreach Program's usability testing as a big point of confusion. Someone created a new template part as a "general" item but named it "header new". Later, when in template part focus mode and when looking at the list of template parts, they tried to find a way to change the categorization but couldn't find an easy way to do so.

annezazu avatar Jul 11 '22 19:07 annezazu

This enhancement would be a requirement for #37943. Otherwise, users won't have access to the template part options.

Mamaduka avatar Jul 21 '22 08:07 Mamaduka

@jameskoster, I'm planning to start working on this (probably early next week). I noticed that the only properties we can edit in focus mode would be the title and area.

Why

In focus mode, we don't have access to the template part block, just its contents, so we cannot change attributes. However, the title and area are stored in the entity, and we can change that.

Mamaduka avatar Aug 05 '22 10:08 Mamaduka

@Mamaduka makes sense, I think those are the most important attributes anyway 👍

jameskoster avatar Aug 05 '22 10:08 jameskoster