gutenberg icon indicating copy to clipboard operation
gutenberg copied to clipboard

Add missing period in block descriptions.

Open audrasjb opened this issue 3 years ago • 3 comments

Description

In the few recent blocks added in last versions of the block editor, some block descriptions were missing a final period. This pull request fix this small consistency issue.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [x] My code is tested.
  • [x] My code follows the WordPress code style.
  • [x] My code follows the accessibility standards.
  • [x] I've tested my changes with keyboard and screen readers.
  • [] My code has proper inline documentation.
  • [] I've included developer documentation if appropriate.
  • [] I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

audrasjb avatar Jun 20 '21 17:06 audrasjb

@audrasjb, it looks like you need to rebase your fork with the trunk from the upstream repository. As far as I can tell, all descriptions end with the period after my update when moving to block.json.

gziolo avatar Jun 22 '21 11:06 gziolo

I have checked the description in all block.json in the latest trunk. Periods are missing in the following two blocks:

https://github.com/WordPress/gutenberg/blob/1b5994afbfc2b42f8e50fa8d04b586e92d6b2a4c/packages/block-library/src/comments-title/block.json#L8 https://github.com/WordPress/gutenberg/blob/1b5994afbfc2b42f8e50fa8d04b586e92d6b2a4c/packages/block-library/src/query-pagination-numbers/block.json#L8

It might be a good idea to rebase this PR and apply the appropriate changes again.

t-hamano avatar Dec 19 '22 13:12 t-hamano

I can confirm that only blocks mentioned by @t-hamano are missing periods.

@audrasjb, it might be easier to open a new PR to fix the issue.

Mamaduka avatar Jan 31 '23 13:01 Mamaduka

I have created a valid #57131 for the latest trunk, so I would like to close this PR.

t-hamano avatar Dec 16 '23 02:12 t-hamano