Add missing auto-escaped function
Yes, I was playing with get_the_privacy_policy_link() in my local and it is a potential hole. I'd escape it with wp_kses_post. At least to avoid Javascript injection until the proper escaping happens inside the function.
Thank you for the welcome :)
So there's a way for unsafe content to be output, but we want to make it as auto-escaped and therefore not flag it? What am I missing here?
@GaryJones Yes, there is a way, but that's no different with nearly every other function in the list. So either we should accept this PR or we should remove all the other functions with similar weaknesses from the list.
By itself, I'd say No for this change, but, I also don't like inconsistencies. I'd reluctantly approve this, if needed.
Perhaps as a separate task we could look at what functions really do provide solid escaping at the last moment, and which make an effort before allowing a filter at the last moment instead.
Based on the above discussion, I'm closing this PR. I've opened a separate issue to review the existing list of "safe functions". See #2119.