Feature to set ip resolver type in request options

Open ShivamYuvraj opened this issue 6 years ago • 3 comments

Dec 11 '19 13:12 ShivamYuvraj

Codecov Report

Merging #375 into master will decrease coverage by 0.09%. The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master     #375      +/-   ##
============================================
- Coverage     92.12%   92.02%   -0.10%     
- Complexity      761      763       +2     
============================================
  Files            21       21              
  Lines          1764     1767       +3     
============================================
+ Hits           1625     1626       +1     
- Misses          139      141       +2

Impacted Files	Coverage Δ	Complexity Δ
library/Requests.php	`75.59% <ø> (ø)`	`118.00 <0.00> (ø)`
library/Requests/Transport/cURL.php	`92.82% <33.33%> (-0.87%)`	`68.00 <0.00> (+2.00)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 58a0bbc...3a8caf8. Read the comment docs.

Dec 11 '19 13:12 codecov-io

@ShivamYuvraj Thank you for contributing. Would it be possible to add some unit tests for this change ?

Dec 12 '19 15:12 jrfnl

Any idea on how to implement a unit test that would not add yet another dependency on an external host?

Mar 15 '20 12:03 ozh